[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: hw/net/rocker: Dubious code in tx_consume()
|
From: |
Jiri Pirko |
|
Subject: |
Re: hw/net/rocker: Dubious code in tx_consume() |
|
Date: |
Sun, 16 Feb 2020 07:59:54 +0100 |
Sat, Feb 15, 2020 at 02:15:22PM CET, address@hidden wrote:
>Hi Jiri,
>
>I am trying to understand this code Scott Feldman added in commit
>dc488f88806:
>
> 157 static int tx_consume(Rocker *r, DescInfo *info)
> 158 {
> ...
> 212 if (tlvs[ROCKER_TLV_TX_TSO_MSS]) {
> 213 tx_tso_mss = rocker_tlv_get_le16(tlvs[ROCKER_TLV_TX_TSO_MSS]);
> 214 }
> ...
> 252 if (iovcnt) {
> 253 /* XXX perform Tx offloads */
> 254 /* XXX silence compiler for now */
> 255 tx_l3_csum_off += tx_tso_mss = tx_tso_hdr_len = 0;
> 256 }
>
>Nobody complained TSO_MSS is not implemented during almost 5 years.
>Can we remove this code?
Yes, you can.
>
>Thanks,
>
>Phil.
>