qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

hw/net/rocker: Dubious code in tx_consume()


From: Philippe Mathieu-Daudé
Subject: hw/net/rocker: Dubious code in tx_consume()
Date: Sat, 15 Feb 2020 14:15:22 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

Hi Jiri,

I am trying to understand this code Scott Feldman added in commit dc488f88806:

 157 static int tx_consume(Rocker *r, DescInfo *info)
 158 {
 ...
 212     if (tlvs[ROCKER_TLV_TX_TSO_MSS]) {
 213         tx_tso_mss = rocker_tlv_get_le16(tlvs[ROCKER_TLV_TX_TSO_MSS]);
 214     }
 ...
 252     if (iovcnt) {
 253         /* XXX perform Tx offloads */
 254         /* XXX   silence compiler for now */
 255         tx_l3_csum_off += tx_tso_mss = tx_tso_hdr_len = 0;
 256     }

Nobody complained TSO_MSS is not implemented during almost 5 years.
Can we remove this code?

Thanks,

Phil.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]