[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 fixed 06/16] exec: Reuse qemu_ram_apply_settings() in qemu_ram
From: |
David Hildenbrand |
Subject: |
[PATCH v2 fixed 06/16] exec: Reuse qemu_ram_apply_settings() in qemu_ram_remap() |
Date: |
Wed, 12 Feb 2020 14:42:44 +0100 |
I don't see why we shouldn't apply all settings to make it look like the
surrounding RAM (and enable proper VMA merging).
Note: memory backend settings might have overridden these settings. We
would need a callback to let the memory backend fix that up.
Reviewed-by: Richard Henderson <address@hidden>
Cc: Richard Henderson <address@hidden>
Cc: Paolo Bonzini <address@hidden>
Cc: Igor Mammedov <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
---
exec.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/exec.c b/exec.c
index 31a462a7d3..f7525867ec 100644
--- a/exec.c
+++ b/exec.c
@@ -2552,8 +2552,7 @@ void qemu_ram_remap(ram_addr_t addr, ram_addr_t length)
length, addr);
exit(1);
}
- memory_try_enable_merging(vaddr, length);
- qemu_ram_setup_dump(vaddr, length);
+ qemu_ram_apply_settings(vaddr, length);
}
}
}
--
2.24.1
- Re: [PATCH v2 fixed 01/16] util: vfio-helpers: Factor out and fix processing of existing ram blocks, (continued)
[PATCH v2 fixed 02/16] util: vfio-helpers: Fix qemu_vfio_close(), David Hildenbrand, 2020/02/12
[PATCH v2 fixed 03/16] util: vfio-helpers: Remove Error parameter from qemu_vfio_undo_mapping(), David Hildenbrand, 2020/02/12
[PATCH v2 fixed 04/16] util: vfio-helpers: Factor out removal from qemu_vfio_undo_mapping(), David Hildenbrand, 2020/02/12
[PATCH v2 fixed 06/16] exec: Reuse qemu_ram_apply_settings() in qemu_ram_remap(),
David Hildenbrand <=
[PATCH v2 fixed 05/16] exec: Factor out setting ram settings (madvise ...) into qemu_ram_apply_settings(), David Hildenbrand, 2020/02/12
[PATCH v2 fixed 07/16] exec: Drop "shared" parameter from ram_block_add(), David Hildenbrand, 2020/02/12
[PATCH v2 fixed 08/16] util/mmap-alloc: Factor out calculation of pagesize to mmap_pagesize(), David Hildenbrand, 2020/02/12