Re: [PATCH v2 33/33] block: Drop @child_class from bdrv_child_perm()

[Eric Blake]

On 2/4/20 11:08 AM, Max Reitz wrote:
> Implementations should decide the necessary permissions based on @role.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
>   block.c                     | 45 ++++++++++++++++---------------------
>   block/backup-top.c          |  3 +--
>   block/blkdebug.c            |  3 +--
>   block/blklogwrites.c        |  3 +--
>   block/commit.c              |  1 -
>   block/copy-on-read.c        |  1 -
>   block/mirror.c              |  1 -
>   block/quorum.c              |  1 -
>   block/replication.c         |  1 -
>   block/vvfat.c               |  4 +---
>   include/block/block_int.h   |  4 +---
>   tests/test-bdrv-drain.c     | 19 +---------------
>   tests/test-bdrv-graph-mod.c |  1 -
>   13 files changed, 25 insertions(+), 62 deletions(-)

Nice diffstat.

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org