Re: [PATCH] Add support for a helper with 7 arguments

[Richard Henderson]

On 2/5/20 10:41 PM, Taylor Simpson wrote:
> Currently, helpers can only take up to 6 arguments.  This patch adds the
> capability for up to 7 arguments.  I have tested it with the Hexagon port
> that I am preparing for submission.
> 
> Signed-off-by: Taylor Simpson <address@hidden>
> ---
>  include/exec/helper-gen.h   | 13 +++++++++++++
>  include/exec/helper-head.h  |  2 ++
>  include/exec/helper-proto.h |  6 ++++++
>  include/exec/helper-tcg.h   |  7 +++++++
>  4 files changed, 28 insertions(+)

Applied to tcg-next, since this is correct, and it does work.

But I encourage you to re-think your purely mechanical approach to the hexagon
port.  It seems to me that you should be doing much more during the translation
phase so that you can minimize the number of helpers that you require.


r~