[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/29] qga/qapi-schema.json: Fix missing '-' in GuestDiskBusT
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 04/29] qga/qapi-schema.json: Fix missing '-' in GuestDiskBusType doc comment |
Date: |
Fri, 07 Feb 2020 09:16:03 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Peter Maydell <address@hidden> writes:
> The doc comment for GuestDiskBusType doesn't match up with the
> enumeration because of a missing hyphen in 'file-backed-virtual'.
> This means the docs are rendered wrongly:
> "virtual"
> Win virtual bus type "file-backed" virtual: Win file-backed bus
> type
I expected a funny rendering, but not this one. The doc generator is
full of surprises...
>
> "file-backed-virtual"
> Not documented
> Add the missing hyphen.
>
> Signed-off-by: Peter Maydell <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
> qga/qapi-schema.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
> index fb4605cc19c..23ce6af597d 100644
> --- a/qga/qapi-schema.json
> +++ b/qga/qapi-schema.json
> @@ -809,7 +809,7 @@
> # @sas: Win serial-attaches SCSI bus type
> # @mmc: Win multimedia card (MMC) bus type
> # @virtual: Win virtual bus type
> -# @file-backed virtual: Win file-backed bus type
> +# @file-backed-virtual: Win file-backed bus type
> #
> # Since: 2.2; 'Unknown' and all entries below since 2.4
> ##
Reviewed-by: Markus Armbruster <address@hidden>
[PATCH 03/29] Makefile: Fix typo in dependency list for interop manpages, Peter Maydell, 2020/02/06
[PATCH 04/29] qga/qapi-schema.json: Fix missing '-' in GuestDiskBusType doc comment, Peter Maydell, 2020/02/06
- Re: [PATCH 04/29] qga/qapi-schema.json: Fix missing '-' in GuestDiskBusType doc comment,
Markus Armbruster <=
[PATCH 05/29] qga/qapi-schema.json: Fix indent level on doc comments, Peter Maydell, 2020/02/06
[PATCH 06/29] qga/qapi-schema.json: minor format fixups for rST, Peter Maydell, 2020/02/06
[PATCH 07/29] qapi/block-core.json: Use literal block for ascii art, Peter Maydell, 2020/02/06