[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 04/46] python/qemu: qmp: Make QEMUMonitorProtocol a context manage
From: |
Philippe Mathieu-Daudé |
Subject: |
[PULL 04/46] python/qemu: qmp: Make QEMUMonitorProtocol a context manager |
Date: |
Thu, 6 Feb 2020 22:18:54 +0100 |
From: Wainer dos Santos Moschetta <address@hidden>
This implement the __enter__ and __exit__ functions on
QEMUMonitorProtocol class so that it can be used on 'with'
statement and the resources will be free up on block end:
with QEMUMonitorProtocol(socket_path) as qmp:
qmp.connect()
qmp.command('query-status')
Signed-off-by: Wainer dos Santos Moschetta <address@hidden>
Reviewed-by: John Snow <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
python/qemu/qmp.py | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/python/qemu/qmp.py b/python/qemu/qmp.py
index 0e07d80e2a..486a566da0 100644
--- a/python/qemu/qmp.py
+++ b/python/qemu/qmp.py
@@ -139,6 +139,15 @@ class QEMUMonitorProtocol:
raise QMPConnectError("Error while reading from socket")
self.__sock.settimeout(None)
+ def __enter__(self):
+ # Implement context manager enter function.
+ return self
+
+ def __exit__(self, exc_type, exc_value, exc_traceback):
+ # Implement context manager exit function.
+ self.close()
+ return False
+
def connect(self, negotiate=True):
"""
Connect to the QMP Monitor and perform capabilities negotiation.
@@ -265,8 +274,10 @@ class QEMUMonitorProtocol:
"""
Close the socket and socket file.
"""
- self.__sock.close()
- self.__sockfile.close()
+ if self.__sock:
+ self.__sock.close()
+ if self.__sockfile:
+ self.__sockfile.close()
def settimeout(self, timeout):
"""
--
2.21.1
- [PULL 00/46] Python queue 2020-02-06, Philippe Mathieu-Daudé, 2020/02/06
- [PULL 01/46] python/qemu: qmp: Replace socket.error with OSError, Philippe Mathieu-Daudé, 2020/02/06
- [PULL 02/46] python/qemu: Delint the qmp module, Philippe Mathieu-Daudé, 2020/02/06
- [PULL 04/46] python/qemu: qmp: Make QEMUMonitorProtocol a context manager,
Philippe Mathieu-Daudé <=
- [PULL 05/46] python/qemu: qmp: Remove unnused attributes, Philippe Mathieu-Daudé, 2020/02/06
- [PULL 03/46] python/qemu: qmp: Make accept()'s timeout configurable, Philippe Mathieu-Daudé, 2020/02/06
- [PULL 06/46] python/qemu: accel: Fix kvm_available() on ppc64le, Philippe Mathieu-Daudé, 2020/02/06
- [PULL 07/46] qemu-deprecated: Remove text about Python 2, Philippe Mathieu-Daudé, 2020/02/06
- [PULL 08/46] python: Treat None-return of greeting cmd, Philippe Mathieu-Daudé, 2020/02/06
- [PULL 09/46] python/qemu/machine: Allow to use other serial consoles than default, Philippe Mathieu-Daudé, 2020/02/06
- [PULL 10/46] Acceptance tests: Extract _console_interaction(), Philippe Mathieu-Daudé, 2020/02/06
- [PULL 11/46] Acceptance tests: Add interrupt_interactive_console_until_pattern(), Philippe Mathieu-Daudé, 2020/02/06
- [PULL 12/46] travis.yml: install rpm2cpio for acceptance tests, Philippe Mathieu-Daudé, 2020/02/06
- [PULL 13/46] tests/boot_linux_console: add extract_from_rpm method, Philippe Mathieu-Daudé, 2020/02/06