qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 0/5] python/qemu: qmp: Fix, delint and improvements


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 0/5] python/qemu: qmp: Fix, delint and improvements
Date: Thu, 6 Feb 2020 15:52:48 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

On 2/4/20 3:11 PM, Wainer dos Santos Moschetta wrote:
I started fixing an issue on exception handling which in some places
currently use the deprecated (in Python 3.3) `socket.error`. Then I
ended up delinting the module code and making some improvements.

Changes in v2:
- Rebased to master. No conflicts.
- Added docstring describing the allowed value of the new `timeout`
   option in accept() (patch 03) [jsnow]
- Set the new `timeout` option to 15.0 by default [philmd]

v1: https://www.mail-archive.com/address@hidden/msg667479.html

Git:
- Tree: https://github.com/wainersm/qemu
- Branch: python_qmp_sockets_error-v2

CI:
- Travis (FAIL): https://travis-ci.org/wainersm/qemu/builds/645583812
   Jobs failures aren't related with these changes


Wainer dos Santos Moschetta (5):
   python/qemu: qmp: Replace socket.error with OSError
   python/qemu: Delint the qmp module
   python/qemu: qmp: Make accept()'s timeout configurable
   python/qemu: qmp: Make QEMUMonitorProtocol a context manager
   python/qemu: qmp: Remove unnused attributes

  python/qemu/qmp.py | 97 +++++++++++++++++++++++++++++++++-------------
  1 file changed, 71 insertions(+), 26 deletions(-)


Patches 3 and 4 applied to my python-next tree:
https://gitlab.com/philmd/qemu/commits/python-next




reply via email to

[Prev in Thread] Current Thread [Next in Thread]