[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 12/22] target/arm: default SVE length to 64 bytes for linu
From: |
Richard Henderson |
Subject: |
Re: [PATCH v6 12/22] target/arm: default SVE length to 64 bytes for linux-user |
Date: |
Thu, 6 Feb 2020 11:19:12 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 2/5/20 5:10 PM, Alex Bennée wrote:
> - /* with maximum vector length */
> + /* with reasonable vector length */
> env->vfp.zcr_el[1] = cpu_isar_feature(aa64_sve, cpu) ?
> - cpu->sve_max_vq - 1 : 0;
> + MIN(cpu->sve_max_vq - 1, 3) : 0;
> env->vfp.zcr_el[2] = env->vfp.zcr_el[1];
> env->vfp.zcr_el[3] = env->vfp.zcr_el[1];
Let's reorg this to
if (cpu_isar_feature(aa64_sve, cpu)) {
env->vfp.zcr_el[1] = MIN(cpu->sve_max_vq - 1, 3);
env->vfp.zcr_el[2] = cpu->sve_max_vq - 1;
env->vfp.zcr_el[3] = cpu->sve_max_vq - 1;
}
Using the MIN setting on el2 and el3 was wrong, as it meant that we could *not*
increase the setting later with PR_SVE_SET_VL, at least not without changes to
linux-user...
r~
- Re: [PATCH v6 13/22] target/arm: generate xml description of our SVE registers, (continued)
- [PATCH v6 17/22] tests/guest-debug: add a simple test runner, Alex Bennée, 2020/02/05
- [PATCH v6 09/22] gdbstub: extend GByteArray to read register helpers, Alex Bennée, 2020/02/05
- [PATCH v6 22/22] gdbstub: do not split gdb_monitor_write payload, Alex Bennée, 2020/02/05
- [PATCH v6 15/22] tests/tcg/aarch64: userspace system register test, Alex Bennée, 2020/02/05
- [PATCH v6 21/22] gdbstub: change GDBState.last_packet to GByteArray, Alex Bennée, 2020/02/05
- [PATCH v6 11/22] target/arm: explicitly encode regnum in our XML, Alex Bennée, 2020/02/05
- [PATCH v6 20/22] tests/tcg/aarch64: add test-sve-ioctl guest-debug test, Alex Bennée, 2020/02/05
- [PATCH v6 19/22] tests/tcg/aarch64: add SVE iotcl test, Alex Bennée, 2020/02/05
- [PATCH v6 12/22] target/arm: default SVE length to 64 bytes for linux-user, Alex Bennée, 2020/02/05
- Re: [PATCH v6 12/22] target/arm: default SVE length to 64 bytes for linux-user,
Richard Henderson <=
- [PATCH v6 18/22] tests/tcg/aarch64: add a gdbstub testcase for SVE registers, Alex Bennée, 2020/02/05
- Re: [PATCH v6 00/22] gdbstub refactor and SVE support, no-reply, 2020/02/05