[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v6 06/22] target/arm: use gdb_get_reg helpers
From: |
Alex Bennée |
Subject: |
[PATCH v6 06/22] target/arm: use gdb_get_reg helpers |
Date: |
Wed, 5 Feb 2020 17:10:15 +0000 |
This is cleaner than poking memory directly and will make later
clean-ups easier.
Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
---
v2
- make sure we pass hi/lo correctly as quads are stored in LE order
---
target/arm/helper.c | 18 +++++++-----------
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/target/arm/helper.c b/target/arm/helper.c
index 19a57a17da5..b417b33cd3b 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -105,21 +105,17 @@ static int aarch64_fpu_gdb_get_reg(CPUARMState *env,
uint8_t *buf, int reg)
{
switch (reg) {
case 0 ... 31:
- /* 128 bit FP register */
- {
- uint64_t *q = aa64_vfp_qreg(env, reg);
- stq_le_p(buf, q[0]);
- stq_le_p(buf + 8, q[1]);
- return 16;
- }
+ {
+ /* 128 bit FP register - quads are in LE order */
+ uint64_t *q = aa64_vfp_qreg(env, reg);
+ return gdb_get_reg128(buf, q[1], q[0]);
+ }
case 32:
/* FPSR */
- stl_p(buf, vfp_get_fpsr(env));
- return 4;
+ return gdb_get_reg32(buf, vfp_get_fpsr(env));
case 33:
/* FPCR */
- stl_p(buf, vfp_get_fpcr(env));
- return 4;
+ return gdb_get_reg32(buf,vfp_get_fpcr(env));
default:
return 0;
}
--
2.20.1
- [PATCH v6 00/22] gdbstub refactor and SVE support, Alex Bennée, 2020/02/05
- [PATCH v6 04/22] gdbstub: move mem_buf to GDBState and use GByteArray, Alex Bennée, 2020/02/05
- [PATCH v6 03/22] gdbstub: move str_buf to GDBState and use GString, Alex Bennée, 2020/02/05
- [PATCH v6 05/22] gdbstub: add helper for 128 bit registers, Alex Bennée, 2020/02/05
- [PATCH v6 01/22] gdbstub: make GDBState static and have common init function, Alex Bennée, 2020/02/05
- [PATCH v6 07/22] target/m68k: use gdb_get_reg helpers, Alex Bennée, 2020/02/05
- [PATCH v6 08/22] target/i386: use gdb_get_reg helpers, Alex Bennée, 2020/02/05
- [PATCH v6 06/22] target/arm: use gdb_get_reg helpers,
Alex Bennée <=
- [PATCH v6 10/22] target/arm: prepare for multiple dynamic XMLs, Alex Bennée, 2020/02/05
- [PATCH v6 02/22] gdbstub: stop passing GDBState * around and use global, Alex Bennée, 2020/02/05
- [PATCH v6 16/22] configure: allow user to specify what gdb to use, Alex Bennée, 2020/02/05
- [PATCH v6 14/22] target/arm: don't bother with id_aa64pfr0_read for USER_ONLY, Alex Bennée, 2020/02/05
- [PATCH v6 13/22] target/arm: generate xml description of our SVE registers, Alex Bennée, 2020/02/05
- [PATCH v6 17/22] tests/guest-debug: add a simple test runner, Alex Bennée, 2020/02/05
- [PATCH v6 09/22] gdbstub: extend GByteArray to read register helpers, Alex Bennée, 2020/02/05
- [PATCH v6 22/22] gdbstub: do not split gdb_monitor_write payload, Alex Bennée, 2020/02/05