qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 06/33] block: Pass BdrvChildRole to .inherit_options()


From: Eric Blake
Subject: Re: [PATCH v2 06/33] block: Pass BdrvChildRole to .inherit_options()
Date: Wed, 5 Feb 2020 10:18:26 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

On 2/4/20 11:08 AM, Max Reitz wrote:
Signed-off-by: Max Reitz <address@hidden>

Another sparse commit message.

---
  block.c                   | 40 +++++++++++++++++++++++----------------
  block/block-backend.c     |  3 ++-
  block/vvfat.c             |  3 ++-
  include/block/block_int.h |  3 ++-
  4 files changed, 30 insertions(+), 19 deletions(-)

diff --git a/block.c b/block.c
index 7fa7830428..612e86fab9 100644
--- a/block.c
+++ b/block.c
@@ -77,6 +77,7 @@ static BlockDriverState *bdrv_open_inherit(const char 
*filename,
                                             QDict *options, int flags,
                                             BlockDriverState *parent,
                                             const BdrvChildClass *child_class,
+                                           BdrvChildRole child_role,

And another question about proper typing.

And another:
Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]