Re: [PATCH v3 2/2] Acceptance test: provides to use different transport for migration

[Philippe Mathieu-Daudé]

On 2/4/20 4:02 PM, Oksana Voshchana wrote:
> Hi Philippe
> You can do whatever it takes
> I appreciate you for a review
> Thanks

OK I'll split as suggested then.

> On Tue, Feb 4, 2020 at 4:12 PM Philippe Mathieu-Daudé <address@hidden 
> <mailto:address@hidden>> wrote:
>
>     On 2/3/20 12:16 PM, Oksana Vohchana wrote:
>      > Along with VM migration via TCP, we can use migration through EXEC
>      > and UNIX transport protocol
>      >
>      > Signed-off-by: Oksana Vohchana <address@hidden
>     <mailto:address@hidden>>
>      > ---
>      > v2:
>      >    - Removes unnecessary symbols and unused method
>      >
>      > v3:
>      >   - Makes refactoring and split into 2 patches
>      >   - Provides TCP and EXEC migration
>      > Signed-off-by: Oksana Vohchana <address@hidden
>     <mailto:address@hidden>>
>      > ---
>      >   tests/acceptance/migration.py | 16 ++++++++++++++++
>      >   1 file changed, 16 insertions(+)
>      >
>      > diff --git a/tests/acceptance/migration.py
>     b/tests/acceptance/migration.py
>      > index 34263d8eeb..4419e38384 100644
>      > --- a/tests/acceptance/migration.py
>      > +++ b/tests/acceptance/migration.py
>      > @@ -10,10 +10,13 @@
>      >   # later.  See the COPYING file in the top-level directory.
>      >
>      >
>      > +import tempfile
>      >   from avocado_qemu import Test
>      > +from avocado import skipUnless
>      >
>      >   from avocado.utils import network
>      >   from avocado.utils import wait
>      > +from avocado.utils.path import find_command
>      >
>      >
>      >   class Migration(Test):
>      > @@ -54,3 +57,16 @@ class Migration(Test):
>      >       def test_migration_with_tcp_localhost(self):
>      >           dest_uri = 'tcp:localhost:%u' % self._get_free_port()
>      >           self.do_migrate(dest_uri)
>      > +
>      > +    def test_migration_with_unix(self):
>      > +        with tempfile.TemporaryDirectory(prefix='socket_') as
>     socket_path:
>      > +            dest_uri = 'unix:%s/qemu-test.sock' % socket_path
>      > +            self.do_migrate(dest_uri)
>
>     Similarly, do you mind if I split and update subjects to "Test the UNIX
>     transport when migrating" and "Test the TCP transport when migrating"?
>
>     Meanwhile:
>     Reviewed-by: Philippe Mathieu-Daudé <address@hidden
>     <mailto:address@hidden>>
>
>      > +
>      > +    @skipUnless(find_command('nc', default=False), "nc command
>     not found on the system")
>      > +    def test_migration_with_exec(self):
>      > +        """
>      > +        The test works for both netcat-traditional and
>     netcat-openbsd packages
>      > +        """
>      > +        free_port = self._get_free_port()
>      > +        dest_uri = 'exec:nc -l localhost %u' % free_port
>      > +        src_uri = 'exec:nc localhost %u' % free_port
>      > +        self.do_migrate(dest_uri, src_uri)
>      >