[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] configure: Allow user to specify sphinx-build binary
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH 1/2] configure: Allow user to specify sphinx-build binary |
Date: |
Tue, 4 Feb 2020 13:37:01 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 |
On 04/02/20 11:39, Markus Armbruster wrote:
> Peter Maydell <address@hidden> writes:
>
>> Currently we insist on using 'sphinx-build' from the $PATH;
>> allow the user to specify the binary to use. This will be
>> more useful as we become pickier about the capabilities
>> we require (eg needing a Python 3 sphinx-build).
>>
>> Signed-off-by: Peter Maydell <address@hidden>
>> ---
>> I went with the most common convention for specifying "here's
>> an executable", like --make=, --install=, --python=....
>>
>> The only odd one out for our current configure options seems to be
>> that we want --with-git=GIT, not --git=GIT. You could argue that
>> that's a better convention,
>
> It's the one Autoconf uses.
>
>> but it makes more sense to me to
>> stick with the convention we currently mostly have. (Perhaps
>> we should even change --with-git= to --git= ?)
>
> Paolo, any implications on the Meson conversion?
Nope, there will still be a handwritten configure script (and in the
beginning it will be pretty much the same as now; in due time, it will
handle command line parsing only).
Paolo