Re: [RFC PATCH] audio: proper support for float samples in mixeng

[Eric Blake]

On 2/3/20 12:21 AM, Markus Armbruster wrote:
> "Kővágó, Zoltán" <address@hidden> writes:
>
> > This adds proper support for float samples in mixeng by adding a new
> > audio format for it.
> >
> > Limitations: only native endianness is supported.
> >
> > Signed-off-by: Kővágó, Zoltán <address@hidden>
> > ---
> >
> > This patch is meant to be applied on top of "[PATCH] coreaudio: fix coreaudio
> > playback" by Volker Rümelin, available at:
> > https://lists.nongnu.org/archive/html/qemu-devel/2020-02/msg00114.html
> >
> > For more information, please refer to that thread.
> >
> > ---

> > +++ b/qapi/audio.json
> > @@ -276,7 +276,7 @@
> >   # Since: 4.0
> >   ##
> >   { 'enum': 'AudioFormat',
> > -  'data': [ 'u8', 's8', 'u16', 's16', 'u32', 's32' ] }
> > +  'data': [ 'u8', 's8', 'u16', 's16', 'u32', 's32', 'f32' ] }
> >   
> >   ##
> >   # @AudiodevDriver:
>
> For QAPI:
> Acked-by: Markus Armbruster <address@hidden>

Is it worth a comment update mentioning that 'f32' is '(since 5.0)'?


--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org