qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 00/17] Improve qcow2 all-zero detection


From: Eric Blake
Subject: [PATCH 00/17] Improve qcow2 all-zero detection
Date: Fri, 31 Jan 2020 11:44:19 -0600

Based-on: <address@hidden>
([PATCH v2 1/2] qemu-img: Add --target-is-zero to convert)

I'm working on adding an NBD extension that reports whether an image
is already all zero when the client first connects.  I initially
thought I could write the NBD code to just call bdrv_has_zero_init(),
but that turned out to be a bad assumption that instead resulted in
this patch series.  The NBD patch will come later (and cross-posted to
the NBD protocol, libnbd, nbdkit, and qemu, as it will affect all four
repositories).

I do have an RFC question on patch 13 - as implemented here, I set a
qcow2 bit if the image has all clusters known zero and no backing
image.  But it may be more useful to instead report whether all
clusters _allocated in this layer_ are zero, at which point the
overall image is all-zero only if the backing file also has that
property (or even make it two bits).  The tweaks to subsequent patches
based on what we think makes the most useful semantics shouldn't be
hard.

[repo.or.cz appears to be down as I type this; I'll post a link to a
repository later when it comes back up]

Eric Blake (17):
  qcow2: Comment typo fixes
  qcow2: List autoclear bit names in header
  qcow2: Avoid feature name extension on small cluster size
  block: Improve documentation of .bdrv_has_zero_init
  block: Don't advertise zero_init_truncate with encryption
  block: Improve bdrv_has_zero_init_truncate with backing file
  gluster: Drop useless has_zero_init callback
  sheepdog: Consistently set bdrv_has_zero_init_truncate
  block: Refactor bdrv_has_zero_init{,_truncate}
  block: Add new BDRV_ZERO_OPEN flag
  file-posix: Support BDRV_ZERO_OPEN
  gluster: Support BDRV_ZERO_OPEN
  qcow2: Add new autoclear feature for all zero image
  qcow2: Expose all zero bit through .bdrv_known_zeroes
  qcow2: Implement all-zero autoclear bit
  iotests: Add new test for qcow2 all-zero bit
  qcow2: Let qemu-img check cover all-zero bit

 block.c                    |  62 +++++----
 block/file-posix.c         |  16 ++-
 block/file-win32.c         |   3 +-
 block/gluster.c            |  34 +++--
 block/nfs.c                |   7 +-
 block/parallels.c          |   4 +-
 block/qcow.c               |   2 +-
 block/qcow2-refcount.c     |  60 +++++++-
 block/qcow2-snapshot.c     |  11 ++
 block/qcow2.c              | 150 +++++++++++++++++---
 block/qcow2.h              |   6 +-
 block/qed.c                |   3 +-
 block/raw-format.c         |  12 +-
 block/rbd.c                |   3 +-
 block/sheepdog.c           |   7 +-
 block/ssh.c                |   7 +-
 block/vdi.c                |   8 +-
 block/vhdx.c               |  16 +--
 block/vmdk.c               |   9 +-
 block/vpc.c                |   8 +-
 blockdev.c                 |   2 +-
 docs/interop/qcow2.txt     |  15 +-
 include/block/block.h      |  38 ++++-
 include/block/block_int.h  |  14 +-
 qapi/block-core.json       |   4 +
 qemu-img.c                 |   9 +-
 tests/qemu-iotests/031.out |  14 +-
 tests/qemu-iotests/036     |   6 +-
 tests/qemu-iotests/036.out |  10 +-
 tests/qemu-iotests/060.out |   6 +-
 tests/qemu-iotests/061     |   6 +-
 tests/qemu-iotests/061.out |  26 ++--
 tests/qemu-iotests/065     |  12 +-
 tests/qemu-iotests/082.out |   7 +
 tests/qemu-iotests/122     |   2 +-
 tests/qemu-iotests/188     |   2 +-
 tests/qemu-iotests/188.out |   2 +-
 tests/qemu-iotests/206.out |   4 +
 tests/qemu-iotests/242.out |   1 +
 tests/qemu-iotests/285     | 124 +++++++++++++++++
 tests/qemu-iotests/285.out | 277 +++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/group   |   1 +
 42 files changed, 832 insertions(+), 178 deletions(-)
 create mode 100755 tests/qemu-iotests/285
 create mode 100644 tests/qemu-iotests/285.out

-- 
2.24.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]