[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] python: Treat None-return of greeting cmd

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] python: Treat None-return of greeting cmd
Date: Thu, 30 Jan 2020 23:16:30 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2

On 1/20/20 8:12 AM, Lukáš Doktor wrote:
In case qemu process dies the "monitor.cmd" returns None which gets
passed to the "__negotiate_capabilities" and leads to unhandled
exception. Let's only check the resp in case it has a value.

Signed-off-by: Lukáš Doktor <address@hidden>
  python/qemu/qmp.py | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/python/qemu/qmp.py b/python/qemu/qmp.py
index 5c8cf6a056..a3e5de718a 100644
--- a/python/qemu/qmp.py
+++ b/python/qemu/qmp.py
@@ -73,7 +73,7 @@ class QEMUMonitorProtocol(object):
              raise QMPConnectError
          # Greeting seems ok, negotiate capabilities
          resp = self.cmd('qmp_capabilities')
-        if "return" in resp:
+        if resp and "return" in resp:
              return greeting
          raise QMPCapabilitiesError

Thanks, applied to my python-next tree:

reply via email to

[Prev in Thread] Current Thread [Next in Thread]