[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 4/5] hw/display/qxl.c: Use trace_event_get_state_backends()
From: |
Stefan Hajnoczi |
Subject: |
[PULL 4/5] hw/display/qxl.c: Use trace_event_get_state_backends() |
Date: |
Thu, 30 Jan 2020 21:38:13 +0000 |
From: Peter Maydell <address@hidden>
The preferred way to test whether a trace event is enabled is to
use trace_event_get_state_backends(), because this will give the
correct answer (allowing expensive computations to be skipped)
whether the trace event is compile-time or run-time disabled.
Convert the old-style direct use of TRACE_FOO_ENABLED.
Signed-off-by: Peter Maydell <address@hidden>
Acked-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden
Message-Id: <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
hw/display/qxl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/display/qxl.c b/hw/display/qxl.c
index 944c02ce56..c33b1915a5 100644
--- a/hw/display/qxl.c
+++ b/hw/display/qxl.c
@@ -1764,7 +1764,7 @@ async_common:
qxl_set_mode(d, val, 0);
break;
case QXL_IO_LOG:
- if (TRACE_QXL_IO_LOG_ENABLED || d->guestdebug) {
+ if (trace_event_get_state_backends(TRACE_QXL_IO_LOG) || d->guestdebug)
{
/* We cannot trust the guest to NUL terminate d->ram->log_buf */
char *log_buf = g_strndup((const char *)d->ram->log_buf,
sizeof(d->ram->log_buf));
--
2.24.1
- [PULL 0/5] Tracing patches, Stefan Hajnoczi, 2020/01/30
- [PULL 1/5] Makefile: Keep trace-events-subdirs ordered, Stefan Hajnoczi, 2020/01/30
- [PULL 2/5] docs/devel/tracing.txt: Recommend only trace_event_get_state_backends(), Stefan Hajnoczi, 2020/01/30
- [PULL 4/5] hw/display/qxl.c: Use trace_event_get_state_backends(),
Stefan Hajnoczi <=
- [PULL 3/5] memory.c: Use trace_event_get_state_backends(), Stefan Hajnoczi, 2020/01/30
- [PULL 5/5] qemu_set_log_filename: filename argument may be NULL, Stefan Hajnoczi, 2020/01/30
- Re: [PULL 0/5] Tracing patches, Peter Maydell, 2020/01/31
- Re: [PULL 0/5] Tracing patches, Peter Maydell, 2020/01/31