[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] hw/*/Makefile.objs: Move many .o files to common-objs

From: Paolo Bonzini
Subject: Re: [PATCH v2] hw/*/Makefile.objs: Move many .o files to common-objs
Date: Thu, 30 Jan 2020 17:33:28 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1

On 30/01/20 15:36, Alex Bennée wrote:
>> We have many files that apparently do not depend on the target CPU
>> configuration, i.e. which can be put into common-obj-y instead of
>> obj-y.
> While common-obj-y is still shared by linux-user this will also add
> slightly to user-only build times.

It won't, all the directories that Thomas is touching are under ifeq
($(CONFIG_SOFTMMU), y)...endif in hw/Makefile.objs.

> I'd like to see some separation of:
>  common-user-obj
>  common-sys-obj

That actually is done in the Meson conversion, where they are called
respectively user_ss and softmmu_ss ("ss" stands for sourceset).  They
are added like so to common_ss:

common_ss.add_all(when: 'CONFIG_SOFTMMU', if_true: softmmu_ss)
common_ss.add_all(when: 'CONFIG_USER_ONLY', if_true: user_ss)

> and I guess the stuff already common to everything is already in
> libqemuutil.a

In my meson-poc branch, the only files that are added directly to
common_ss rather than softmmu_ss or user_ss are the files in hw/core and
the disassemblers.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]