Re: [PATCH v2 19/29] tests/acceptance/virtio_check_params: Only test Xen as superuser

[Philippe Mathieu-Daudé]

On 1/30/20 1:37 PM, Cornelia Huck wrote:
> On Wed, 29 Jan 2020 22:23:35 +0100
> Philippe Mathieu-Daudé <address@hidden> wrote:
>
> > When running the test unprivileged, we get:
> >
> >    $ avocado --show=app,machine run tests/acceptance/virtio_check_params.py
> >    JOB ID     : b631d5d692e49b791b211d33b80730315d561d45
> >    JOB LOG    : job-results/job-2020-01-22T17.56-b631d5d/job.log
> >     (1/1) 
> > tests/acceptance/virtio_check_params.py:VirtioMaxSegSettingsCheck.test_machine_types:
> >    machine: {'name': 'pc-i440fx-2.12', 'seg_max_adjust': 'false', 'device': 
> > 'virtio-scsi-pci'}
> >    machine: {'name': 'pc-i440fx-2.0', 'seg_max_adjust': 'false', 'device': 
> > 'virtio-scsi-pci'}
> >    machine: {'name': 'xenpv', 'seg_max_adjust': 'false', 'device': 
> > 'virtio-scsi-pci'}
> >    FAIL: machine type xenpv: <class 'qemu.qmp.QMPConnectError'> (0.40 s)
> >
> > Looking at the job.log file we find:
> >
> >    xencall: error: Could not obtain handle on privileged command interface: No 
> > such file or directory
> >    xen be core: xen be core: can't open xen interface
> >
> > Do not run this test on Xen machines if not superuser.
> >
> > Acked-by: Cornelia Huck <address@hidden>
> > Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> > ---
> >   tests/acceptance/virtio_check_params.py | 2 ++
> >   1 file changed, 2 insertions(+)
>
> I still think changing the title to "Test Xen only as superuser" would
> be an improvement.

If it fits the 72chars in patch subject, I'm happy to change :)