[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 29/29] MAINTAINERS: Add Acceptance tests reviewers

From: Thomas Huth
Subject: Re: [PATCH v2 29/29] MAINTAINERS: Add Acceptance tests reviewers
Date: Thu, 30 Jan 2020 09:41:49 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0

On 29/01/2020 22.23, Philippe Mathieu-Daudé wrote:
> Acceptance tests can test any piece of the QEMU codebase.
> As such, the directory holding them does not belong to a specific
> subsystem with designated maintainers.
> Each subsystem covered by a test is welcomed to add the test path
> to its section.
> See for example commits 71b290e70, b11785ca2 or 5d480ddde.
> Since Eduardo, Cleber and Philippe have been reviewing the patches
> on the list, add them as reviewers.
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> Cc: Wainer dos Santos Moschetta <address@hidden>
> Wainer do you want to be listed?
> ---
>  MAINTAINERS | 6 ++++++
>  1 file changed, 6 insertions(+)
> index efd3f3875f..4a3cc3f137 100644
> @@ -2733,6 +2733,12 @@ S: Maintained
>  F: tests/tcg/Makefile
>  F: tests/tcg/Makefile.include
> +Acceptance Tests
> +R: Eduardo Habkost <address@hidden>
> +R: Cleber Rosa <address@hidden>
> +R: Philippe Mathieu-Daudé <address@hidden>
> +F: tests/acceptance/

Many files under tests/acceptance/ are not covered by a maintainer at
all, e.g.:

 $ scripts/get_maintainer.pl -f tests/acceptance/boot_linux_console.py
 get_maintainer.pl: No maintainers found, printing recent contributors.

... so I think it would be good to have someone who feels at least a
little bit responsible to do the maintainers work here and picks up
patches to put them into a pull request. Any volunteers?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]