Re: [PATCH] tests/acceptance: Add boot tests for some of the QEMU advent calendar images

[Thomas Huth]

On 29/01/2020 18.48, BALATON Zoltan wrote:
> On Wed, 29 Jan 2020, Thomas Huth wrote:
>> On 27/01/2020 18.31, Wainer dos Santos Moschetta wrote:
>>> On 1/24/20 3:03 PM, Thomas Huth wrote:
>>>> The 2018 edition of the QEMU advent calendar 2018 featured Linux images
>>>> for various non-x86 machines. We can use them for a boot tests in our
>>>> acceptance test suite.
>>>>
>>>> Let's also make sure that we build the corresponding machines in
>>>> Travis,
>>>> and while we're there, drop the superfluous --python parameter (python3
>>>> is now the only supported version anyway).
>>>>
>>>> Signed-off-by: Thomas Huth <address@hidden>
>>>> ---
>> [...]
>>>> +    def test_ppc_g3beige(self):
>>>> +        """
>>>> +        :avocado: tags=arch:ppc
>>>> +        :avocado: tags=machine:g3beige
>>>> +        """
>>>> +        tar_hash = 'e0b872a5eb8fdc5bed19bd43ffe863900ebcedfc'
>>>> +        self.vm.add_args('-M', 'graphics=off')
>>>> +        self.do_test_advcal_2018('15', tar_hash, 'invaders.elf')
>>>
>>> Hi Thomas, let me check one thing...
>>>
>>> The VM will be launched as:
>>>
>>> ----
>>>
>>> ppc-softmmu/qemu-system-ppc -display none -vga none -chardev
>>> socket,id=mon,path=/tmp/tmpvdokyvs3/qemu-41146-monitor.sock -mon
>>> chardev=mon,mode=control -machine g3beige -chardev
>>> socket,id=console,path=/tmp/tmpvdokyvs3/qemu-41146-console.sock,server,nowait
>>>
>>> -serial chardev:console -M graphics=off -kernel
>>> /tmp/avocado_g3uccfo5/avocado_job_61gglyz3/02-tests_acceptance_boot_linux_console.py_BootLinuxConsole.test_ppc_g3beige/day15/invaders.elf
>>>
>>>
>>>
>>> ----
>>>
>>> Note that it passes '[..] -machine g3beige [...] -M graphics=off [...]'.
>>> I suspect you wanted '-machine g3beige,graphics=off'. am I right?
>>
>> No, the -M graphics=off was intended.
>>
>>> or
>>> QEMU will interpret the -M option as a parameter of the already set
>>> machine type?
>>
>> That's exactly the case.
>>
>>> or the -M overwrites -machine, and because  g3beige is the
>>> default type it just works?
>>
>> No, the default machine of qemu-system-ppc is mac99.
> 
> I think you're wrong about the default machine type:
> 
> $ qemu-system-ppc -M help
> Supported machines are:
> 40p                  IBM RS/6000 7020 (40p)
> bamboo               bamboo
> g3beige              Heathrow based PowerMAC (default)
> 
> g3beige is marked as default and seems to be created without any -M
> option

Oops, thanks, I stand corrected.

 Thomas