[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] hw/i386/vmmouse: Fix crash when using the vmmouse on a machi

From: Darren Kenny
Subject: Re: [PATCH] hw/i386/vmmouse: Fix crash when using the vmmouse on a machine without vmport
Date: Wed, 29 Jan 2020 11:35:56 +0000
User-agent: NeoMutt/20180716

On Wed, Jan 29, 2020 at 12:29:54PM +0100, Thomas Huth wrote:
QEMU currently crashes when the user tries to use the "vmmouse" on a
machine without vmport, e.g.:

$ x86_64-softmmu/qemu-system-x86_64 -machine microvm -device vmmouse
Segmentation fault (core dumped)


$ x86_64-softmmu/qemu-system-x86_64 -device vmmouse -M pc,vmport=off
Segmentation fault (core dumped)

Let's avoid the crash by checking for the vmport device first.

Signed-off-by: Thomas Huth <address@hidden>

Makes sense.

Reviewed-by: Darren Kenny <address@hidden>



hw/i386/vmmouse.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/hw/i386/vmmouse.c b/hw/i386/vmmouse.c
index 7c2a375527..e8e62bd96b 100644
--- a/hw/i386/vmmouse.c
+++ b/hw/i386/vmmouse.c
@@ -23,6 +23,7 @@

#include "qemu/osdep.h"
+#include "qapi/error.h"
#include "ui/console.h"
#include "hw/i386/pc.h"
#include "hw/input/i8042.h"
@@ -269,6 +270,11 @@ static void vmmouse_realizefn(DeviceState *dev, Error 


+    if (!object_resolve_path_type("", TYPE_VMPORT, NULL)) {
+        error_setg(errp, "vmmouse needs a machine with vmport");
+        return;
+    }
    vmport_register(VMMOUSE_STATUS, vmmouse_ioport_read, s);
    vmport_register(VMMOUSE_COMMAND, vmmouse_ioport_read, s);
    vmport_register(VMMOUSE_DATA, vmmouse_ioport_read, s);

reply via email to

[Prev in Thread] Current Thread [Next in Thread]