[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 08/13] monitor/hmp: move hmp_nbd_server* to block-hmp-cmds

From: Eric Blake
Subject: Re: [PATCH v3 08/13] monitor/hmp: move hmp_nbd_server* to block-hmp-cmds.c
Date: Tue, 28 Jan 2020 14:05:44 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

On 1/28/20 12:56 PM, Dr. David Alan Gilbert wrote:
* Maxim Levitsky (address@hidden) wrote:
Signed-off-by: Maxim Levitsky <address@hidden>

Yes, I think that's OK; I can imagine nbd might want to move on it's own
somewhere since it's not really core block code; copying in Eric.

I think that nbd-server-start and friends ARE related to core block code; they do not work without a BDS node. It's not the same as a block driver, though, in that it is exposing the BDS to the outside world, rather than connecting an outside resource for use internally by the guest.

At any rate, block-hmp-cmds.c seems reasonable enough as a new location for these HMP commands.

Reviewed-by: Dr. David Alan Gilbert <address@hidden>

  block/monitor/block-hmp-cmds.c     | 88 ++++++++++++++++++++++++++++++
  include/block/block-hmp-commands.h |  5 ++
  include/monitor/hmp.h              |  4 --
  monitor/hmp-cmds.c                 | 87 -----------------------------
  4 files changed, 93 insertions(+), 91 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]