[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] mirror: Store MirrorOp.co for debuggability

From: Eric Blake
Subject: Re: [PATCH 1/2] mirror: Store MirrorOp.co for debuggability
Date: Tue, 28 Jan 2020 10:26:05 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

On 1/28/20 9:17 AM, Kevin Wolf wrote:
If a coroutine is launched, but the coroutine pointer isn't stored
anywhere, debugging any problems inside the coroutine is quite hard.
Let's store the coroutine pointer of a mirror operation in MirrorOp to
have it available in the debugger.

Signed-off-by: Kevin Wolf <address@hidden>
  block/mirror.c | 2 ++
  1 file changed, 2 insertions(+)

Doesn't change semantics other than an unobservable performance delay; but the rewards in improved debugability warrant it.

Reviewed-by: Eric Blake <address@hidden>

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]