Re: [PATCH] .travis.yml: Add description to each job

[Wainer dos Santos Moschetta]

On 1/26/20 5:54 AM, Thomas Huth wrote:
> On 25/01/2020 19.31, Philippe Mathieu-Daudé wrote:
> > The NAME variable can be used to describe nicely a job (see [*]).
> > As we currently have 32 jobs, use it. This helps for quickly
> > finding a particular job.
> >
> >    before: https://travis-ci.org/qemu/qemu/builds/639887646
> >    after: https://travis-ci.org/philmd/qemu/builds/641795043
> Very good idea, correlating a job in the GUI to an entry in the yml file
> was really a pain, so far.
>
> > [*] 
> > https://docs.travis-ci.com/user/customizing-the-build/#naming-jobs-within-matrices
> >
> > Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> > ---
> >   .travis.yml | 101 ++++++++++++++++++++++++++++++++++------------------
> >   1 file changed, 67 insertions(+), 34 deletions(-)
> >
> > diff --git a/.travis.yml b/.travis.yml
> > index 6c1038a0f1..d68e35a2c5 100644
> > --- a/.travis.yml
> > +++ b/.travis.yml
> > @@ -94,24 +94,28 @@ after_script:
> >   
> >   matrix:
> >     include:
> > -    - env:
> > +    - name: "[x86] GCC static (user)"
> Could you please drop the [x86] and other architectures from the names?
> Travis already lists the build architecture in the job status page, so
> this information is redundant.
>
> [...]


I agree on dropping the architecture from the names, so:

Reviewed-by: Wainer dos Santos Moschetta <address@hidden>


> >       # Alternate coroutines implementations are only really of interest to KVM 
> > users
> >       # However we can't test against KVM on Travis so we can only run unit 
> > tests


Yet another off-topic comment: If we switch those coroutine test jobs to 
Bionic then we can use KVM.

- Wainer

> > -    - env:
> > +    - name: "[x86] check-unit coroutine=ucontext"
> > +      env:
> >           - CONFIG="--with-coroutine=ucontext --disable-tcg"
> >           - TEST_CMD="make check-unit -j3 V=1"
> >   
> >   
> > -    - env:
> > +    - name: "[x86] check-unit coroutine=sigaltstack"
> > +      env:
> >           - CONFIG="--with-coroutine=sigaltstack --disable-tcg"
> >           - TEST_CMD="make check-unit -j3 V=1"
> Off-topic to your patch, but aren't coroutines something that is only
> used in the softmmu targets? If so, we could add --disable-user to the
> above two builds to speed things up a little bit.
>
> >   
> >       # Check we can build docs and tools (out of tree)
> > -    - env:
> > +    - name: "[x86] tools and docs"
> > +      env:
> >           - BUILD_DIR="out-of-tree/build/dir" SRC_DIR="../../.."
> Also off-topic, but I think we can now remove the above line and fix the
> comment - since all builds are now out-of-tree anyway, see commit
> bc4486fb233573e.
>
>
> > @@ -250,7 +271,8 @@ matrix:
> >   
> >   
> >       # Python builds
> > -    - env:
> > +    - name: "[x86] GCC Python 3.5 (x86_64-softmmu)"
> > +      env:
> Off-topic again:
> Python 3.5 is the default on xenial, and since we stopped using Python
> 2.7, I think we could remove this job now.
>
> We could add some jobs with Bionic + Python 3.7 and 3.8 instead.
>
> >           - CONFIG="--target-list=x86_64-softmmu"
> >           - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
> >         language: python
> > @@ -258,7 +280,8 @@ matrix:
> >           - "3.5"
> >   
> >   
> > -    - env:
> > +    - name: "[x86] GCC Python 3.6 (x86_64-softmmu)"
> > +      env:
> >           - CONFIG="--target-list=x86_64-softmmu"
> >           - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
> >         language: python
>   Thomas