[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] Implement the Screamer sound chip for the mac99 machine t

From: Volker Rümelin
Subject: Re: [PATCH v2] Implement the Screamer sound chip for the mac99 machine type
Date: Tue, 28 Jan 2020 09:30:50 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2

> Hi,
> Unfortunately it's not that simple to simply revert the patch since the old 
> backend api no longer exists.  Also I don't have a Mac so it's almost 
> impossible for me to test the results.  I looked at the specified commit and 
> I think I found a problem, could you please apply the attached patch on the 
> current git master and check whether it solves the problem?  If yes I'll turn 
> it into a proper patch.
> Regards,
> Zoltan

Hi Zoltán,

I also don't have a Mac so I tested your patch with a slightly modified 
sdlaudio version. I found two bugs in your patch. With the bugs fixed I have 
working SDL2 audio playback with float type samples. Now I wonder if the fixed 
patch also fixes coreaudio playback. Depending on how busy you are I can just 
write a review for your patch and let you handle the rest, or may I send a 
modified version of your patch to the mailing list for testing?

With best regards

reply via email to

[Prev in Thread] Current Thread [Next in Thread]