[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 111/111] virtiofsd: add some options to the help message
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [PULL 111/111] virtiofsd: add some options to the help message |
Date: |
Mon, 27 Jan 2020 19:45:04 +0000 |
User-agent: |
Mutt/1.13.0 (2019-11-30) |
* Christophe de Dinechin (address@hidden) wrote:
>
> Dr. David Alan Gilbert (git) writes:
>
> > From: Masayoshi Mizuma <address@hidden>
> >
> > Add following options to the help message:
> > - cache
> > - flock|no_flock
> > - norace
> > - posix_lock|no_posix_lock
> > - readdirplus|no_readdirplus
> > - timeout
> > - writeback|no_writeback
> > - xattr|no_xattr
> >
> > Signed-off-by: Masayoshi Mizuma <address@hidden>
> >
> > dgilbert: Split cache, norace, posix_lock, readdirplus off
> > into our own earlier patches that added the options
> >
> > Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> > Reviewed-by: Misono Tomohiro <address@hidden>
> > Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> > ---
> > tools/virtiofsd/helper.c | 10 +++++++++-
> > 1 file changed, 9 insertions(+), 1 deletion(-)
> >
> > diff --git a/tools/virtiofsd/helper.c b/tools/virtiofsd/helper.c
> > index f98d8f2eb2..0801cf752c 100644
> > --- a/tools/virtiofsd/helper.c
> > +++ b/tools/virtiofsd/helper.c
> > @@ -148,6 +148,8 @@ void fuse_cmdline_help(void)
> > " -o cache=<mode> cache mode. could be one of
> > \"auto, "
> > "always, none\"\n"
> > " default: auto\n"
> > + " -o flock|no_flock enable/disable flock\n"
> > + " default: no_flock\n"
> > " -o log_level=<level> log level, default to
> > \"info\"\n"
> > " level could be one of \"debug, "
> > "info, warn, err\"\n"
> > @@ -163,7 +165,13 @@ void fuse_cmdline_help(void)
> > " enable/disable readirplus\n"
> > " default: readdirplus except
> > with "
> > "cache=none\n"
> > - );
> > + " -o timeout=<number> I/O timeout (second)\n"
>
> s/second/seconds/ ? (Not sure, I'm not a native speaker)
Yes, it should.
Dave
> > + " default: depends on cache=
> > option.\n"
> > + " -o writeback|no_writeback enable/disable writeback
> > cache\n"
> > + " default: no_writeback\n"
> > + " -o xattr|no_xattr enable/disable xattr\n"
> > + " default: no_xattr\n"
> > + );
> > }
> >
> > static int fuse_helper_opt_proc(void *data, const char *arg, int key,
>
>
> --
> Cheers,
> Christophe de Dinechin (IRC c3d)
>
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [PULL 102/111] virtiofsd: add definition of fuse_buf_writev(), (continued)
- [PULL 102/111] virtiofsd: add definition of fuse_buf_writev(), Dr. David Alan Gilbert (git), 2020/01/23
- [PULL 106/111] virtiofsd: fix lo_destroy() resource leaks, Dr. David Alan Gilbert (git), 2020/01/23
- [PULL 094/111] virtiofsd: add man page, Dr. David Alan Gilbert (git), 2020/01/23
- [PULL 109/111] virtiofsd/passthrough_ll: Pass errno to fuse_reply_err(), Dr. David Alan Gilbert (git), 2020/01/23
- [PULL 110/111] virtiofsd: stop all queue threads on exit in virtio_loop(), Dr. David Alan Gilbert (git), 2020/01/23
- [PULL 108/111] virtiofsd: Convert lo_destroy to take the lo->mutex lock itself, Dr. David Alan Gilbert (git), 2020/01/23
- [PULL 105/111] virtiofsd: prevent FUSE_INIT/FUSE_DESTROY races, Dr. David Alan Gilbert (git), 2020/01/23
- [PULL 104/111] virtiofsd: process requests in a thread pool, Dr. David Alan Gilbert (git), 2020/01/23
- [PULL 111/111] virtiofsd: add some options to the help message, Dr. David Alan Gilbert (git), 2020/01/23
- [PULL 096/111] virtiofsd: introduce inode refcount to prevent use-after-free, Dr. David Alan Gilbert (git), 2020/01/23
- [PULL 103/111] virtiofsd: use fuse_buf_writev to replace fuse_buf_write for better performance, Dr. David Alan Gilbert (git), 2020/01/23
- Re: [PULL 000/111] virtiofs queue, Peter Maydell, 2020/01/23
Re: [PULL 000/111] virtiofs queue, no-reply, 2020/01/23