Re: [PATCH v4 5/7] tests/boot_linux_console: Test booting U-Boot on the Raspberry Pi 2

[Philippe Mathieu-Daudé]

On 1/27/20 5:02 PM, Thomas Huth wrote:
> On 21/01/2020 00.51, Philippe Mathieu-Daudé wrote:
> > This test runs U-Boot on the Raspberry Pi 2.
> > It is very simple and fast:
> >
> >    $ avocado --show=app,console run -t raspi2 -t u-boot tests/acceptance/
> >    JOB LOG    : avocado/job-results/job-2020-01-20T23.40-2424777/job.log
> >     (1/1) 
> > tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_raspi2_uboot:
> >    console: MMC:   sdhci@7e300000: 0
> >    console: Loading Environment from FAT... Card did not respond to voltage 
> > select!
> >    console: In:    serial
> >    console: Out:   vidconsole
> >    console: Err:   vidconsole
> >    console: Net:   No ethernet found.
> >    console: starting USB...
> >    console: USB0:   Port not available.
> >    console: Hit any key to stop autoboot:  0
> >    console: U-Boot>
> >    console: U-Boot> bdinfo
> >    console: arch_number = 0x00000000
> >    console: boot_params = 0x00000100
> >    console: DRAM bank   = 0x00000000
> >    console: -> start    = 0x00000000
> >    console: -> size     = 0x3c000000
> >    console: baudrate    = 115200 bps
> >    console: TLB addr    = 0x3bff0000
> >    console: relocaddr   = 0x3bf64000
> >    console: reloc off   = 0x3bf5c000
> >    console: irq_sp      = 0x3bb5fec0
> >    console: sp start    = 0x3bb5feb0
> >    console: Early malloc usage: 2a4 / 400
> >    console: fdt_blob    = 0x3bfbdfb0
> >    console: U-Boot> version
> >    console: U-Boot 2019.01+dfsg-7 (May 14 2019 - 02:07:44 +0000)
> >    console: gcc (Debian 8.3.0-7) 8.3.0
> >    console: GNU ld (GNU Binutils for Debian) 2.31.1
> >    console: U-Boot> reset
> >    console: resetting ...
> >    PASS (0.46 s)
> >
> > U-Boot is built by the Debian project, see:
> > https://wiki.debian.org/InstallingDebianOn/Allwinner#Creating_a_bootable_SD_Card_with_u-boot
> >
> > Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> > ---
> >   tests/acceptance/boot_linux_console.py | 28 ++++++++++++++++++++++++++
> >   1 file changed, 28 insertions(+)
> >
> > diff --git a/tests/acceptance/boot_linux_console.py 
> > b/tests/acceptance/boot_linux_console.py
> > index e40b84651b..682b801b4f 100644
> > --- a/tests/acceptance/boot_linux_console.py
> > +++ b/tests/acceptance/boot_linux_console.py
>
> The file is called boot_*linux*_console.py ... so shouldn't tests that
> don't use Linux rather go into another file instead?
> Either machine_arm_raspi.py or maybe a boot_firmware_console.py file?

Yes I have a series ready splitting boot_linux_console.py per machines 
(as suggested machine_arm_raspi.py) not for consistency with fw/linux 
but because I'm tired of fixing conflicts while rebasing since months.