Re: [PATCH 2/8] tests/vm: increased max timeout for vm boot.

[Philippe Mathieu-Daudé]

On 1/24/20 8:00 PM, Robert Foley wrote:
> Hi Phil,
>
> > I once suggested "When using TCG, wait longer for a VM to start"
> > https://www.mail-archive.com/address@hidden/msg550610.html
> Thanks for the pointer.  This increase in timeout under TCG seems just
> right for the case we saw.  I will incorporate this into the patch.

Well I'm not sure this is the better way, at the time I posted the 
series (see cover) there was no upstream interest in vmtests with TCG on 
aarch64, so I did not insist.

I'm glad you are improving this area now.

> On Fri, 24 Jan 2020 at 12:12, Philippe Mathieu-Daudé <address@hidden> wrote:
> > Hi Robert,
> >
> > On 1/24/20 5:53 PM, Robert Foley wrote:
> > > Add change to increase timeout waiting for VM to boot.
> > > Needed for some emulation cases where it can take longer
> > > than 5 minutes to boot.
> > >
> > > Signed-off-by: Robert Foley <address@hidden>
> > > Reviewed-by: Peter Puhov <address@hidden>
> > > ---
> > >    tests/vm/basevm.py | 2 +-
> > >    1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py
> > > index 991115e44b..86908f58ec 100755
> > > --- a/tests/vm/basevm.py
> > > +++ b/tests/vm/basevm.py
> > > @@ -310,7 +310,7 @@ class BaseVM(object):
> > >        def print_step(self, text):
> > >            sys.stderr.write("### %s ...\n" % text)
> > >
> > > -    def wait_ssh(self, seconds=300):
> > > +    def wait_ssh(self, seconds=600):
> > >            starttime = datetime.datetime.now()
> > >            endtime = starttime + datetime.timedelta(seconds=seconds)
> > >            guest_up = False
> >
> > I once suggested "When using TCG, wait longer for a VM to start"
> > https://www.mail-archive.com/address@hidden/msg550610.html
> >
> > Cleber took some notes about 'kicking a expiring timer' but I can't find
> > it. This might be related:
> > https://trello.com/c/MYdgH4mz/90-delayed-failures
> >
> > Regards,
> >
> > Phil.