[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 12/21] multifd: multifd_queue_page only needs the qemufile
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [PATCH v3 12/21] multifd: multifd_queue_page only needs the qemufile |
Date: |
Fri, 24 Jan 2020 11:37:46 +0000 |
User-agent: |
Mutt/1.13.0 (2019-11-30) |
* Juan Quintela (address@hidden) wrote:
> Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> migration/ram.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/migration/ram.c b/migration/ram.c
> index 19caf5ed4d..d4c829bc77 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -974,7 +974,7 @@ static int multifd_send_pages(QEMUFile *f)
> return 1;
> }
>
> -static int multifd_queue_page(RAMState *rs, RAMBlock *block, ram_addr_t
> offset)
> +static int multifd_queue_page(QEMUFile *f, RAMBlock *block, ram_addr_t
> offset)
> {
> MultiFDPages_t *pages = multifd_send_state->pages;
>
> @@ -993,12 +993,12 @@ static int multifd_queue_page(RAMState *rs, RAMBlock
> *block, ram_addr_t offset)
> }
> }
>
> - if (multifd_send_pages(rs->f) < 0) {
> + if (multifd_send_pages(f) < 0) {
> return -1;
> }
>
> if (pages->block != block) {
> - return multifd_queue_page(rs, block, offset);
> + return multifd_queue_page(f, block, offset);
> }
>
> return 1;
> @@ -2128,7 +2128,7 @@ static int ram_save_page(RAMState *rs, PageSearchStatus
> *pss, bool last_stage)
> static int ram_save_multifd_page(RAMState *rs, RAMBlock *block,
> ram_addr_t offset)
> {
> - if (multifd_queue_page(rs, block, offset) < 0) {
> + if (multifd_queue_page(rs->f, block, offset) < 0) {
> return -1;
> }
> ram_counters.normal++;
> --
> 2.24.1
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- Re: [PATCH v3 07/21] migration: Make multifd_save_setup() get an Error parameter, (continued)
- [PATCH v3 08/21] migration: Make multifd_load_setup() get an Error parameter, Juan Quintela, 2020/01/23
- [PATCH v3 10/21] ram_addr: Split RAMBlock definition, Juan Quintela, 2020/01/23
- [PATCH v3 09/21] migration: Add multifd-compress parameter, Juan Quintela, 2020/01/23
- [PATCH v3 11/21] multifd: multifd_send_pages only needs the qemufile, Juan Quintela, 2020/01/23
- [PATCH v3 12/21] multifd: multifd_queue_page only needs the qemufile, Juan Quintela, 2020/01/23
- Re: [PATCH v3 12/21] multifd: multifd_queue_page only needs the qemufile,
Dr. David Alan Gilbert <=
- [PATCH v3 13/21] multifd: multifd_send_sync_main only needs the qemufile, Juan Quintela, 2020/01/23
- [PATCH v3 14/21] multifd: Use qemu_target_page_size(), Juan Quintela, 2020/01/23
- [PATCH v3 15/21] migration: Make checkpatch happy with comments, Juan Quintela, 2020/01/23
- [PATCH v3 16/21] migration: Add support for modules, Juan Quintela, 2020/01/23
- [PATCH v3 18/21] migration: Make no compression operations into its own structure, Juan Quintela, 2020/01/23