[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/7] migration/block-dirty-bitmap: keep bitmap state for all
From: |
Juan Quintela |
Subject: |
Re: [PATCH 4/7] migration/block-dirty-bitmap: keep bitmap state for all bitmaps |
Date: |
Fri, 24 Jan 2020 12:01:38 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Vladimir Sementsov-Ogievskiy <address@hidden> wrote:
> Keep bitmap state for disabled bitmaps too. Keep the state until the
> end of the process. It's needed for the following commit to implement
> bitmap postcopy canceling.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> -
> - b = g_new(DirtyBitmapLoadBitmapState, 1);
> - b->bs = s->bs;
> - b->bitmap = s->bitmap;
> - b->migrated = false;
> - dbm_load_state.enabled_bitmaps =
> - g_slist_prepend(dbm_load_state.enabled_bitmaps, b);
> }
>
> + b = g_new(DirtyBitmapLoadBitmapState, 1);
> + *b = (DirtyBitmapLoadBitmapState) {
> + .bs = s->bs,
> + .bitmap = s->bitmap,
> + .migrated = false,
> + .enabled = flags & DIRTY_BITMAP_MIG_START_FLAG_ENABLED,
> + };
What is wrong with:
b->bs = s->bs;
b->bitmap = s->bitmap;
b->migrated = false;
b->enabled = flags & DIRTY_BITMAP_MIG_START_FLAG_ENABLED;
???
Later, Juan.
- [PATCH 0/7] Fix crashes on early shutdown during bitmaps postcopy, Vladimir Sementsov-Ogievskiy, 2020/01/22
- [PATCH 3/7] migration/block-dirty-bitmap: simplify dirty_bitmap_load_complete, Vladimir Sementsov-Ogievskiy, 2020/01/22
- [PATCH 5/7] migration/block-dirty-bitmap: cancel migration on shutdown, Vladimir Sementsov-Ogievskiy, 2020/01/22
- [PATCH 6/7] migration: handle to_src_file on target only for ram postcopy, Vladimir Sementsov-Ogievskiy, 2020/01/22
- [PATCH 7/7] qemu-iotests/199: add early shutdown case to bitmaps postcopy, Vladimir Sementsov-Ogievskiy, 2020/01/22
- [PATCH 2/7] migration/block-dirty-bitmap: rename finish_lock to just lock, Vladimir Sementsov-Ogievskiy, 2020/01/22
- [PATCH 4/7] migration/block-dirty-bitmap: keep bitmap state for all bitmaps, Vladimir Sementsov-Ogievskiy, 2020/01/22
- Re: [PATCH 4/7] migration/block-dirty-bitmap: keep bitmap state for all bitmaps,
Juan Quintela <=
- [PATCH 1/7] migration/block-dirty-bitmap: refactor incoming state to be one struct, Vladimir Sementsov-Ogievskiy, 2020/01/22