[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH rc2 12/25] hw/timer: Add limited support for Atmel 16 bit tim
From: |
Alex Bennée |
Subject: |
Re: [PATCH rc2 12/25] hw/timer: Add limited support for Atmel 16 bit timer peripheral |
Date: |
Fri, 24 Jan 2020 10:42:19 +0000 |
User-agent: |
mu4e 1.3.6; emacs 28.0.50 |
Philippe Mathieu-Daudé <address@hidden> writes:
> From: Michael Rolnik <address@hidden>
>
> These were designed to facilitate testing but should provide enough
> function to be useful in other contexts. Only a subset of the functions
> of each peripheral is implemented, mainly due to the lack of a standard
> way to handle electrical connections (like GPIO pins).
>
> Signed-off-by: Sarah Harris <address@hidden>
> Message-Id: <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> [rth: Squash info mtree fixes and a file rename from f4bug, which was:]
> Suggested-by: Aleksandar Markovic <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
> [PMD: Use qemu_log_mask(LOG_UNIMP), replace goto by return]
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
<snip>
> --- /dev/null
> +++ b/include/hw/timer/atmel_timer16.h
> @@ -0,0 +1,94 @@
> +/*
> + * Atmel AVR 16 bit timer
> + *
> + * Copyright (c) 2018 University of Kent
> + * Author: Ed Robbins
No sign off from the author here?
> --- /dev/null
> +++ b/hw/timer/atmel_timer16.c
> @@ -0,0 +1,605 @@
<snip>
> +
> +/* Helper macros */
> +#define VAL16(l, h) ((h << 8) | l)
> +#define DB_PRINT(fmt, args...) /* Nothing */
> +/*#define DB_PRINT(fmt, args...) printf("%s: " fmt "\n", __func__, ##
> args)*/
Format strings are likely to bitrot. Either use a if (GATE) or
tracepoints.
<snip>
Otherwise:
Reviewed-by: Alex Bennée <address@hidden>
--
Alex Bennée
- [PATCH rc2 10/25] target/avr: Add instruction disassembly function, (continued)
- [PATCH rc2 10/25] target/avr: Add instruction disassembly function, Philippe Mathieu-Daudé, 2020/01/23
- [PATCH rc2 11/25] hw/char: Add limited support for Atmel USART peripheral, Philippe Mathieu-Daudé, 2020/01/23
- [PATCH rc2 13/25] hw/misc: Add Atmel power device, Philippe Mathieu-Daudé, 2020/01/23
- [PATCH rc2 14/25] target/avr: Add section about AVR into QEMU documentation, Philippe Mathieu-Daudé, 2020/01/23
- [PATCH rc2 12/25] hw/timer: Add limited support for Atmel 16 bit timer peripheral, Philippe Mathieu-Daudé, 2020/01/23
- Re: [PATCH rc2 12/25] hw/timer: Add limited support for Atmel 16 bit timer peripheral, Philippe Mathieu-Daudé, 2020/01/24
[PATCH rc2 15/25] target/avr: Register AVR support with the rest of QEMU, Philippe Mathieu-Daudé, 2020/01/23
[PATCH rc2 16/25] target/avr: Add machine none test, Philippe Mathieu-Daudé, 2020/01/23
[PATCH rc2 17/25] target/avr: Update MAINTAINERS file, Philippe Mathieu-Daudé, 2020/01/23
[PATCH rc2 18/25] hw/core/loader: Let load_elf populate the processor-specific flags, Philippe Mathieu-Daudé, 2020/01/23
[PATCH rc2 19/25] hw/avr: Add helper to load raw/ELF firmware binaries, Philippe Mathieu-Daudé, 2020/01/23