[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 1/8] dma/pl330: Convert to support tracing

From: Peter Maydell
Subject: Re: [PATCH v3 1/8] dma/pl330: Convert to support tracing
Date: Thu, 23 Jan 2020 15:51:51 +0000

On Thu, 23 Jan 2020 at 05:25, Guenter Roeck <address@hidden> wrote:
> Replace debug logging code with tracing.
> Reviewed-by: Peter Maydell <address@hidden>
> Signed-off-by: Guenter Roeck <address@hidden>

This turns out not to compile on OSX, which is a bit
stricter about format strings:

These two:

> +pl330_dmald(uint32_t chan, uint32_t addr, uint32_t size, uint32_t num, 
> uint32_t ch) "channel:%"PRId8" address:0x%08"PRIx32" size:0x%"PRIx32" 
> num:%"PRId32"%c"

> +pl330_dmast(uint32_t chn, uint32_t addr, uint32_t sz, uint32_t num, uint32_t 
> c) "channel:%"PRId8" address:0x%08"PRIx32" size:0x%"PRIx32" num:%"PRId32" %c"

both provoke
 error: format specifies type 'char' but the argument has type
'uint32_t' (aka 'unsigned int') [-Werror,-Wformat]

because of the last argument.

Easy fix would seem to be to change 'uint32_t ch' to 'char ch'
(the argument is always a literal constant 'Y' or 'N').

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]