[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 10/26] object: add object_property_set_defaut_{bool, str, in
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH 10/26] object: add object_property_set_defaut_{bool, str, int, uint}() |
|
Date: |
Thu, 23 Jan 2020 15:34:03 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 |
On 23/01/20 12:39, Marc-André Lureau wrote:
> Hi
>
> On Thu, Jan 23, 2020 at 3:29 PM Paolo Bonzini <address@hidden> wrote:
>>
>> This patch caught my attention because of the typo in the function, but
>
> Ah! a french "défaut".
I suspected that. :)
>> I also noticed that get_default is never set to anything but
>> object_property_get_defval.
>>
>> What do you think about removing the method and just relying on defval?
>> In practice there would be a new patch that squashes 7, 10 and the thing
>> after my signature.
>
> Indeed, we could remove the get_default callback. I can't find the
> reason I added it now.
>
> Are you resending the series then?
I have already sent a pull request. In the end even
object_property_get_default was only used once so I just inlined it and
dropped patch 7.
Paolo
- [PATCH 04/26] qdev: move helper function to monitor/misc, (continued)
- [PATCH 04/26] qdev: move helper function to monitor/misc, Marc-André Lureau, 2020/01/10
- [PATCH 05/26] object: avoid extra class property key duplication, Marc-André Lureau, 2020/01/10
- [PATCH 06/26] object: add class property initializer, Marc-André Lureau, 2020/01/10
- [PATCH 07/26] object: add object_property_get_defaut(), Marc-André Lureau, 2020/01/10
- [PATCH 08/26] object: make object_class_property_add* return property, Marc-André Lureau, 2020/01/10
- [PATCH 09/26] qstring: add qstring_free(), Marc-André Lureau, 2020/01/10
- [PATCH 10/26] object: add object_property_set_defaut_{bool, str, int, uint}(), Marc-André Lureau, 2020/01/10
- [PATCH 11/26] object: do not free class properties, Marc-André Lureau, 2020/01/10
- [PATCH 12/26] object: check strong flag with &, Marc-André Lureau, 2020/01/10
- [PATCH 13/26] object: rename link "child" to "target", Marc-André Lureau, 2020/01/10
- [PATCH 14/26] object: add direct link flag, Marc-André Lureau, 2020/01/10
- [PATCH 15/26] object: express const link with link property, Marc-André Lureau, 2020/01/10
- [PATCH 16/26] object: add object_class_property_add_link(), Marc-André Lureau, 2020/01/10
- [PATCH 17/26] object: release all props, Marc-André Lureau, 2020/01/10
- [PATCH 18/26] object: return self in object_ref(), Marc-André Lureau, 2020/01/10
- [PATCH 20/26] qdev: move instance properties to class properties, Marc-André Lureau, 2020/01/10