qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PULL 40/59] object: do not free class properties


From: Paolo Bonzini
Subject: [PULL 40/59] object: do not free class properties
Date: Thu, 23 Jan 2020 14:50:30 +0100

From: Marc-André Lureau <address@hidden>

The release callback is called during object_property_del_all(), on a
live instance. But class properties are common among all
instances. It is not currently called, because we don't release
classes, but it would not be correct if we did.

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
 qom/object.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/qom/object.c b/qom/object.c
index 2d29019..864281e 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -2127,7 +2127,7 @@ object_class_property_add_str(ObjectClass *klass, const 
char *name,
     rv = object_class_property_add(klass, name, "string",
                               get ? property_get_str : NULL,
                               set ? property_set_str : NULL,
-                              property_release_str,
+                              NULL,
                               prop, &local_err);
     if (local_err) {
         error_propagate(errp, local_err);
@@ -2220,7 +2220,7 @@ object_class_property_add_bool(ObjectClass *klass, const 
char *name,
     rv = object_class_property_add(klass, name, "bool",
                               get ? property_get_bool : NULL,
                               set ? property_set_bool : NULL,
-                              property_release_bool,
+                              NULL,
                               prop, &local_err);
     if (local_err) {
         error_propagate(errp, local_err);
@@ -2312,7 +2312,7 @@ object_class_property_add_enum(ObjectClass *klass, const 
char *name,
     rv = object_class_property_add(klass, name, typename,
                               get ? property_get_enum : NULL,
                               set ? property_set_enum : NULL,
-                              property_release_enum,
+                              NULL,
                               prop, &local_err);
     if (local_err) {
         error_propagate(errp, local_err);
@@ -2413,7 +2413,7 @@ object_class_property_add_tm(ObjectClass *klass, const 
char *name,
 
     rv = object_class_property_add(klass, name, "struct tm",
                               get ? property_get_tm : NULL, NULL,
-                              property_release_tm,
+                              NULL,
                               prop, &local_err);
     if (local_err) {
         error_propagate(errp, local_err);
-- 
1.8.3.1





reply via email to

[Prev in Thread] Current Thread [Next in Thread]