[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH REPOST v3 10/80] arm/cubieboard: use memdev for RAM
From: |
Andrew Jones |
Subject: |
Re: [PATCH REPOST v3 10/80] arm/cubieboard: use memdev for RAM |
Date: |
Thu, 23 Jan 2020 13:30:11 +0100 |
On Thu, Jan 23, 2020 at 12:37:35PM +0100, Igor Mammedov wrote:
> memory_region_allocate_system_memory() API is going away, so
> replace it with memdev allocated MemoryRegion. The later is
> initialized by generic code, so board only needs to opt in
> to memdev scheme by providing
> MachineClass::default_ram_id
> and using MachineState::ram instead of manually initializing
> RAM memory region.
>
> PS:
> While at it, get rid of no longer needed CubieBoardState wrapper.
>
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
> CC: address@hidden
> CC: address@hidden
> CC: address@hidden
> CC: address@hidden
> ---
> hw/arm/cubieboard.c | 25 ++++++++-----------------
> 1 file changed, 8 insertions(+), 17 deletions(-)
>
I don't know anything about cubieboard, but I promised Igor to put
another pair of eyes on his changes. Looks fine to me.
Reviewed-by: Andrew Jones <address@hidden>
- [PATCH REPOST v3 00/80] refactor main RAM allocation to use hostmem backend, Igor Mammedov, 2020/01/23
- [PATCH REPOST v3 02/80] machine: introduce memory-backend property, Igor Mammedov, 2020/01/23
- [PATCH REPOST v3 01/80] numa: remove deprecated -mem-path fallback to anonymous RAM, Igor Mammedov, 2020/01/23
- [PATCH REPOST v3 03/80] machine: alias -mem-path and -mem-prealloc into memory-foo backend, Igor Mammedov, 2020/01/23
- [PATCH REPOST v3 04/80] machine: introduce convenience MachineState::ram, Igor Mammedov, 2020/01/23
- [PATCH REPOST v3 05/80] initialize MachineState::ram in NUMA case, Igor Mammedov, 2020/01/23
- [PATCH REPOST v3 06/80] alpha:dp264: use memdev for RAM, Igor Mammedov, 2020/01/23
- [PATCH REPOST v3 10/80] arm/cubieboard: use memdev for RAM, Igor Mammedov, 2020/01/23
- Re: [PATCH REPOST v3 10/80] arm/cubieboard: use memdev for RAM,
Andrew Jones <=
- [PATCH REPOST v3 07/80] arm/aspeed: actually check RAM size, Igor Mammedov, 2020/01/23
- [PATCH REPOST v3 09/80] arm/collie: use memdev for RAM, Igor Mammedov, 2020/01/23
- [PATCH REPOST v3 08/80] arm/aspeed: use memdev for RAM, Igor Mammedov, 2020/01/23
- [PATCH REPOST v3 11/80] arm/digic_boards: use memdev for RAM, Igor Mammedov, 2020/01/23
- [PATCH REPOST v3 12/80] arm/highbank: use memdev for RAM, Igor Mammedov, 2020/01/23
- [PATCH REPOST v3 14/80] arm/imx25_pdk: use memdev for RAM, Igor Mammedov, 2020/01/23
- [PATCH REPOST v3 13/80] arm/imx25_pdk: drop RAM size fixup, Igor Mammedov, 2020/01/23