[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Maintainers, please add Message-Id: when merging patches

From: Laszlo Ersek
Subject: Re: Maintainers, please add Message-Id: when merging patches
Date: Wed, 22 Jan 2020 15:10:08 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 01/22/20 13:30, Alex Bennée wrote:
> Stefan Hajnoczi <address@hidden> writes:
>> Around 66% of qemu.git commits since v4.1.0 include a Message-Id: tag.  
>> Hooray!
>> Message-Id: references the patch email that a commit was merged from.
>> This information is helpful to anyone wishing to refer back to email
>> discussions and patch series.
> So I guess the ones that don't are maintainer originated patches unless
> you actively rebuild your trees from a posted series?

I *think* this should not be a huge problem process wise:

Assuming that a maintainer does not include their own patches in a PULL
request for Peter until the same patches receive R-b/A-b/T-b feedback
from other list subscribers, the maintainer will want to rebase the
patches at least once anyway, in order to pick up those lines.

And, in the process, the maintainer might as well add in their own
Message-Id's from the list.

... I realize though, that could be more burden in practice than just
running git-am against the same (known) base commit... One could always
run git-range-diff in the end, to compare the "re-pick" versus the
original local branch.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]