Re: [PATCH 2/5] docs/sphinx: Add new hxtool Sphinx extension

[Richard Henderson]

On 1/21/20 12:22 PM, Peter Maydell wrote:
>> This doesn't seem to work for me.
>>
>> make[1]: Leaving directory '/home/rth/qemu/qemu/slirp'
>> CONFDIR="/home/rth/qemu/run/etc/qemu" sphinx-build  -W -b html -D
>> version=4.2.50 -D release="4.2.50 (rth)" -d .doctrees/devel-html
>> /home/rth/qemu/qemu/docs/devel docs/devel
>> Running Sphinx v1.8.5
>>
>> Extension error:
>> Could not import extension hxtool (exception: cannot import name 
>> ExtensionError)
>> make: *** [Makefile:1022: docs/devel/index.html] Error 2
> 
> I suspect this is an incompatibility (or possibly just a
> dropped back-compatibility I was accidentally relying on)
> between Sphinx 1.7 and 1.8. (I tested with a 1.6 and a 1.7.)
> 
> It looks like ExtensionError is now in sphinx.errors, so if you
> change
> +from sphinx.application import ExtensionError
> 
> to "from sphinx.errors import ExtensionError" does that help?

Yep, that's it.  Thanks,


r~