[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 5/6] hw/core: Restrict reset handlers API to system-mode

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 5/6] hw/core: Restrict reset handlers API to system-mode
Date: Tue, 21 Jan 2020 11:59:12 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2

On 1/20/20 12:07 PM, Alex Bennée wrote:

Philippe Mathieu-Daudé <address@hidden> writes:

The user-mode code does not use this API, restrict it
to the system-mode.

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
  hw/core/Makefile.objs | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/core/Makefile.objs b/hw/core/Makefile.objs
index 0edd9e635d..2fea68ccf7 100644
--- a/hw/core/Makefile.objs
+++ b/hw/core/Makefile.objs
@@ -1,6 +1,7 @@
  # core qdev-related obj files, also used by *-user:
  common-obj-y += qdev.o qdev-properties.o
-common-obj-y += bus.o reset.o
+common-obj-y += bus.o
+common-obj-$(CONFIG_SOFTMMU) += reset.o

This seems a very minor tweaks as far as it goes. I though the only
thing needed in hw was hw/core/cpu and everything else was system

Unfortunately qdev.o pulls in a lot of unnecessary code (qbus, machine properties...).

However it at least moves the needle in the right direction:

Reviewed-by: Alex Bennée <address@hidden>


  common-obj-$(CONFIG_SOFTMMU) += qdev-fw.o
  common-obj-$(CONFIG_SOFTMMU) += fw-path-provider.o
  # irq.o needed for qdev GPIO handling:

reply via email to

[Prev in Thread] Current Thread [Next in Thread]