[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] pvpanic: implement crashloaded event handling
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH 2/2] pvpanic: implement crashloaded event handling |
|
Date: |
Tue, 21 Jan 2020 11:49:53 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 |
On 20/01/20 20:12, Eric Blake wrote:
>> +#
>> +# Example:
>> +#
>> +# <- { "event": "GUEST_CRASHLOADED",
>> +# "data": { "action": "run" } }
>> +#
>> +##
>> +{ 'event': 'GUEST_CRASHLOADED',
>> + 'data': { 'action': 'GuestPanicAction', '*info':
>> 'GuestPanicInformation' } }
>> +
>> +##
>> # @GuestPanicAction:
>> #
>> # An enumeration of the actions taken when guest OS panic is detected
>> @@ -366,7 +386,7 @@
>> # Since: 2.1 (poweroff since 2.8)
>> ##
>> { 'enum': 'GuestPanicAction',
>> - 'data': [ 'pause', 'poweroff' ] }
>> + 'data': [ 'pause', 'poweroff', 'run' ] }
>
> But the comment here could be updated to mention 'run' since 5.0,
> alongside poweroff since 2.8. Not the end of the world if we don't
> annotate it, though, since instrospection still shows the difference.
Done in my local branch.