[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 09/10] nbd/server: use bdrv_dirty_bitmap_next_dirty_area

From: Eric Blake
Subject: Re: [PATCH v3 09/10] nbd/server: use bdrv_dirty_bitmap_next_dirty_area
Date: Mon, 20 Jan 2020 14:23:44 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1

On 12/19/19 4:03 AM, Vladimir Sementsov-Ogievskiy wrote:
Use bdrv_dirty_bitmap_next_dirty_area for bitmap_to_extents. Since
bdrv_dirty_bitmap_next_dirty_area is very accurate in its interface,
we'll never exceed requested region with last chunk. So, we don't need
dont_fragment, and bitmap_to_extents() interface becomes clean enough
to not require any comment.

Not exceeding the requested region means we are giving the client less information than what we already have freely available. I don't know if that will (slightly) pessimize any client that would have otherwise been able to handle the fact that we reported beyond the request (only matters for clients which do not use NBD_CMD_FLAG_REQ_ONE).

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Eric Blake <address@hidden>

But since I've already reviewed it, my R-b still stands.

  nbd/server.c | 59 +++++++++++++++++-----------------------------------
  1 file changed, 19 insertions(+), 40 deletions(-)

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]