[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v7 02/20] module: check module wasn't already initialized
From: |
Bulekov, Alexander |
Subject: |
[PATCH v7 02/20] module: check module wasn't already initialized |
Date: |
Mon, 20 Jan 2020 05:54:42 +0000 |
The virtual-device fuzzer must initialize QOM, prior to running
vl:qemu_init, so that it can use the qos_graph to identify the arguments
required to initialize a guest for libqos-assisted fuzzing. This change
prevents errors when vl:qemu_init tries to (re)initialize the previously
initialized QOM module.
Signed-off-by: Alexander Bulekov <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Darren Kenny <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
---
util/module.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/util/module.c b/util/module.c
index 8c5315a7a3..236a7bb52a 100644
--- a/util/module.c
+++ b/util/module.c
@@ -30,6 +30,7 @@ typedef struct ModuleEntry
typedef QTAILQ_HEAD(, ModuleEntry) ModuleTypeList;
static ModuleTypeList init_type_list[MODULE_INIT_MAX];
+static bool modules_init_done[MODULE_INIT_MAX];
static ModuleTypeList dso_init_list;
@@ -91,11 +92,17 @@ void module_call_init(module_init_type type)
ModuleTypeList *l;
ModuleEntry *e;
+ if (modules_init_done[type]) {
+ return;
+ }
+
l = find_type(type);
QTAILQ_FOREACH(e, l, node) {
e->init();
}
+
+ modules_init_done[type] = true;
}
#ifdef CONFIG_MODULES
--
2.23.0
- [PATCH v7 00/20] Add virtual device fuzzing support, Bulekov, Alexander, 2020/01/20
- [PATCH v7 01/20] softmmu: split off vl.c:main() into main.c, Bulekov, Alexander, 2020/01/20
- [PATCH v7 02/20] libqos: rename i2c_send and i2c_recv, Bulekov, Alexander, 2020/01/20
- [PATCH v7 02/20] module: check module wasn't already initialized,
Bulekov, Alexander <=
- [PATCH v7 03/20] fuzz: add FUZZ_TARGET module type, Bulekov, Alexander, 2020/01/20
- [PATCH v7 04/20] qtest: add qtest_server_send abstraction, Bulekov, Alexander, 2020/01/20
- [PATCH v7 06/20] libqtest: make bufwrite rely on the TransportOps, Bulekov, Alexander, 2020/01/20
- [PATCH v7 05/20] libqtest: add a layer of abstraction to send/recv, Bulekov, Alexander, 2020/01/20
- [PATCH v7 06/20] module: check module wasn't already initialized, Bulekov, Alexander, 2020/01/20
- [PATCH v7 07/20] qtest: add in-process incoming command handler, Bulekov, Alexander, 2020/01/20
- [PATCH v7 08/20] libqos: rename i2c_send and i2c_recv, Bulekov, Alexander, 2020/01/20
- [PATCH v7 08/20] libqos: split qos-test and libqos makefile vars, Bulekov, Alexander, 2020/01/20
- [PATCH v7 09/20] libqos: split qos-test and libqos makefile vars, Bulekov, Alexander, 2020/01/20
- [PATCH v7 09/20] libqos: move useful qos-test funcs to qos_external, Bulekov, Alexander, 2020/01/20