[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 01/11] qapi/error: add (Error **errp) cleaning APIs

From: Eric Blake
Subject: Re: [PATCH v6 01/11] qapi/error: add (Error **errp) cleaning APIs
Date: Fri, 17 Jan 2020 07:15:43 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1

On 1/10/20 1:41 PM, Vladimir Sementsov-Ogievskiy wrote:
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>

Sparse commit message; it might be nice (for future 'git log' greppability) to at least mention the names of the functions being added.

+ * Functions to clean Error **errp: call corresponding Error *err cleaning
+ * function an set pointer to NULL

s/ an/, then/

Missing a '.' at the end of the sentence.

Reviewed-by: Eric Blake <address@hidden>

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]