[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1] vnc: fix VNC artifacts

From: Gerd Hoffmann
Subject: Re: [PATCH v1] vnc: fix VNC artifacts
Date: Fri, 17 Jan 2020 08:45:30 +0100

On Thu, Jan 16, 2020 at 07:50:58PM -0800, Cameron Esfahani wrote:
> Remove VNC optimization to reencode framebuffer update as raw if it's
> smaller than the default encoding.  QEMU's implementation was naive and
> didn't account for the ZLIB z_stream mutating with each compression.  Just
> saving and restoring the output buffer offset wasn't sufficient to "rewind"
> the previous encoding.  Considering that ZRLE is never larger than raw and
> even though ZLIB can occasionally be fractionally larger than raw, the
> overhead of implementing this optimization correctly isn't worth it.

So just revert de3f7de7f4e257 then ...

> In my investigation, ZRLE always compresses better than ZLIB so
> prioritize ZRLE over ZLIB, even if the client hints that ZLIB is
> preferred.

... and make this a separate patch?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]