Re: [PATCH 2/4] tests/tcg/aarch64: Fix compilation parameters for pauth-%

[Philippe Mathieu-Daudé]

On 1/17/20 12:08 AM, Richard Henderson wrote:
> Hiding the required architecture within asm() is not correct.
> Add it to the cflags of the (cross-) compiler.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>   tests/tcg/aarch64/pauth-1.c       | 2 --
>   tests/tcg/aarch64/pauth-2.c       | 2 --
>   tests/tcg/aarch64/Makefile.target | 1 +
>   3 files changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/tests/tcg/aarch64/pauth-1.c b/tests/tcg/aarch64/pauth-1.c
> index a3c1443cd0..ea0984ea82 100644
> --- a/tests/tcg/aarch64/pauth-1.c
> +++ b/tests/tcg/aarch64/pauth-1.c
> @@ -2,8 +2,6 @@
>   #include <sys/prctl.h>
>   #include <stdio.h>
>   
> -asm(".arch armv8.4-a");
> -
>   #ifndef PR_PAC_RESET_KEYS
>   #define PR_PAC_RESET_KEYS  54
>   #define PR_PAC_APDAKEY     (1 << 2)
> diff --git a/tests/tcg/aarch64/pauth-2.c b/tests/tcg/aarch64/pauth-2.c
> index 2fe030ba3d..9bba0beb63 100644
> --- a/tests/tcg/aarch64/pauth-2.c
> +++ b/tests/tcg/aarch64/pauth-2.c
> @@ -1,8 +1,6 @@
>   #include <stdint.h>
>   #include <assert.h>
>   
> -asm(".arch armv8.4-a");
> -
>   void do_test(uint64_t value)
>   {
>       uint64_t salt1, salt2;
> diff --git a/tests/tcg/aarch64/Makefile.target 
> b/tests/tcg/aarch64/Makefile.target
> index df3fe8032c..374c8d6830 100644
> --- a/tests/tcg/aarch64/Makefile.target
> +++ b/tests/tcg/aarch64/Makefile.target
> @@ -20,6 +20,7 @@ run-fcvt: fcvt
>   # Pauth Tests
>   AARCH64_TESTS += pauth-1 pauth-2
>   run-pauth-%: QEMU_OPTS += -cpu max
> +pauth-%: CFLAGS += -march=armv8.3-a

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

>   
>   # Semihosting smoke test for linux-user
>   AARCH64_TESTS += semihosting