[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 5/5] building configuration files changes

From: Kevin Wolf
Subject: Re: [PATCH v2 5/5] building configuration files changes
Date: Thu, 16 Jan 2020 12:07:21 +0100
User-agent: Mutt/1.12.1 (2019-06-15)

Am 14.01.2020 um 15:06 hat Coiby Xu geschrieben:
> libvhost-user depends on sys/poll.h, sys/socket.h and eventfd. Although
> Windows has the equivalent Winsock, it doesn't have eventfd. So only
> enable this feature on Linux.
> Signed-off-by: Coiby Xu <address@hidden>

This shouldn't be a separate patch at the end of the series, but each
patch should make sure that the files it adds are actually built. This
way you can apply individual patches and they still make sense. It also
helps for bisecting.

While applying the patches locally for review, I noticed that there is a
merge conflict with recent changes that moved qos test cases to a
different subdirectory. I resolved the conflict manually, but for v3 you
should rebase.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]