[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 13/13] linux-user: Add support for TYPE_LONG and TYPE_ULON
From: |
Laurent Vivier |
Subject: |
Re: [PATCH v7 13/13] linux-user: Add support for TYPE_LONG and TYPE_ULONG in do_ioctl() |
Date: |
Wed, 15 Jan 2020 22:53:42 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 |
Le 15/01/2020 à 20:12, Filip Bozuta a écrit :
> Function "do_ioctl()" located in file "syscall.c" was missing
> an option for TYPE_LONG and TYPE_ULONG. This caused some ioctls
> to not be recognised because they had the third argument that was
> of type 'long' or 'unsigned long'.
>
> For example:
>
> Since implemented ioctls RTC_IRQP_SET and RTC_EPOCH_SET
> are of type IOW(writing type) that have unsigned long as
> their third argument, they were not recognised in QEMU
> before the changes of this patch.
>
> Signed-off-by: Filip Bozuta <address@hidden>
> ---
> linux-user/syscall.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index a3993a2..2ba2c5c 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -5176,6 +5176,8 @@ static abi_long do_ioctl(int fd, int cmd, abi_long arg)
> break;
> case TYPE_PTRVOID:
> case TYPE_INT:
> + case TYPE_LONG:
> + case TYPE_ULONG:
> ret = get_errno(safe_ioctl(fd, ie->host_cmd, arg));
> break;
> case TYPE_PTR:
>
Reviewed-by: Laurent Vivier <address@hidden>
- [PATCH v7 01/13] linux-user: Add support for enabling/disabling RTC features using ioctls, (continued)
- [PATCH v7 01/13] linux-user: Add support for enabling/disabling RTC features using ioctls, Filip Bozuta, 2020/01/15
- [PATCH v7 05/13] linux-user: Add support for getting/setting RTC PLL correction using ioctls, Filip Bozuta, 2020/01/15
- [PATCH v7 04/13] linux-user: Add support for getting/setting RTC wakeup alarm using ioctls, Filip Bozuta, 2020/01/15
- [PATCH v7 03/13] linux-user: Add support for getting/setting RTC periodic interrupt and epoch using ioctls, Filip Bozuta, 2020/01/15
- [PATCH v7 06/13] linux-user: Add support for read/clear RTC voltage low detector using ioctls, Filip Bozuta, 2020/01/15
- [PATCH v7 07/13] linux-user: Add support for getting alsa timer version and id, Filip Bozuta, 2020/01/15
- [PATCH v7 09/13] linux-user: Add support for getting/setting specified alsa timer parameters using ioctls, Filip Bozuta, 2020/01/15
- [PATCH v7 12/13] linux-user: Add support for selected alsa timer instructions using ioctls, Filip Bozuta, 2020/01/15
- [PATCH v7 10/13] linux-user: Add support for selecting alsa timer using ioctl, Filip Bozuta, 2020/01/15
- [PATCH v7 13/13] linux-user: Add support for TYPE_LONG and TYPE_ULONG in do_ioctl(), Filip Bozuta, 2020/01/15
- Re: [PATCH v7 13/13] linux-user: Add support for TYPE_LONG and TYPE_ULONG in do_ioctl(),
Laurent Vivier <=
- [PATCH v7 11/13] linux-user: Add support for getting/setting selected alsa timer parameters using ioctls, Filip Bozuta, 2020/01/15