[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 02/86] machine: introduce ram-memdev property

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 02/86] machine: introduce ram-memdev property
Date: Wed, 15 Jan 2020 17:57:38 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2

On 1/15/20 5:39 PM, Igor Mammedov wrote:
On Wed, 15 Jan 2020 16:56:30 +0100
Paolo Bonzini <address@hidden> wrote:

On 15/01/20 16:06, Igor Mammedov wrote:
+ object_property_add_link(obj, "ram-memdev", TYPE_MEMORY_BACKEND,
+                             (Object **)&ms->ram_memdev,
+                             object_property_allow_set_link,
+                             OBJ_PROP_LINK_STRONG, &error_abort);
+    object_property_set_description(obj, "ram-memdev",
+                                    "Set RAM backend"
+                                    "Valid value is ID of hostmem based 
+                                     &error_abort);

Obligatory bikeshedding, why not just ram (the MachineState field can
remain "ram_memdev").  Or memory-backend matching the QOM type names.

I'd say it was inspired by "-numa node,memdev" option for some sort of 
But I'm fine with any other name as far as there is consensus.
If I had to choose between 'ram' and 'memory-backend', I'd go for the later.

+1 for "memory-backend".

reply via email to

[Prev in Thread] Current Thread [Next in Thread]