[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 08/12] linux-user: Add support for setting alsa timer enhance
From: |
Arnd Bergmann |
Subject: |
Re: [PATCH 08/12] linux-user: Add support for setting alsa timer enhanced read using ioctl |
Date: |
Wed, 15 Jan 2020 17:18:23 +0100 |
On Wed, Jan 15, 2020 at 4:53 PM Filip Bozuta <address@hidden> wrote:
>
> This patch implements functionality of following ioctl:
>
> SNDRV_TIMER_IOCTL_TREAD - Setting enhanced time read
>
> Sets enhanced time read which is used for reading time with timestamps
> and events. The third ioctl's argument is a pointer to an 'int'. Enhanced
> reading is set if the third argument is different than 0, otherwise normal
> time reading is set.
>
> Implementation notes:
>
> Because the implemented ioctl has 'int' as its third argument, the
> implementation was straightforward.
>
> Signed-off-by: Filip Bozuta <address@hidden>
I think this one is wrong when you go between 32-bit and 64-bit
targets, and it gets worse with the kernel patches that just got
merged for linux-5.5, which extends the behavior to deal with
64-bit time_t on 32-bit architectures.
Please have a look at
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/?h=80fe7430c70859
Arnd
- [PATCH 12/12] linux-user: Add support for selected alsa timer instructions using ioctls, (continued)
- [PATCH 12/12] linux-user: Add support for selected alsa timer instructions using ioctls, Filip Bozuta, 2020/01/09
- [PATCH 11/12] linux-user: Add support for getting/setting selected alsa timer parameters using ioctls, Filip Bozuta, 2020/01/09
- Re: [PATCH 00/12] linux-user: Add support for real time clock and, Philippe Mathieu-Daudé, 2020/01/14
- [PATCH 00/12] linux-user: Add support for real time clock and, Filip Bozuta, 2020/01/15
- [PATCH 04/12] linux-user: Add support for getting/setting RTC wakeup alarm using ioctls, Filip Bozuta, 2020/01/15
- [PATCH 07/12] linux-user: Add support for getting alsa timer version and id, Filip Bozuta, 2020/01/15
- [PATCH 08/12] linux-user: Add support for setting alsa timer enhanced read using ioctl, Filip Bozuta, 2020/01/15
- Re: [PATCH 08/12] linux-user: Add support for setting alsa timer enhanced read using ioctl,
Arnd Bergmann <=
- Re: [PATCH 08/12] linux-user: Add support for setting alsa timer enhanced read using ioctl, Laurent Vivier, 2020/01/15
- Re: [PATCH 08/12] linux-user: Add support for setting alsa timer enhanced read using ioctl, Arnd Bergmann, 2020/01/15
- Re: [PATCH 08/12] linux-user: Add support for setting alsa timer enhanced read using ioctl, Filip Bozuta, 2020/01/15
- Re: [PATCH 08/12] linux-user: Add support for setting alsa timer enhanced read using ioctl, Arnd Bergmann, 2020/01/15
- Re: [PATCH 08/12] linux-user: Add support for setting alsa timer enhanced read using ioctl, Laurent Vivier, 2020/01/15
- Re: [PATCH 08/12] linux-user: Add support for setting alsa timer enhanced read using ioctl, Laurent Vivier, 2020/01/15
- [PATCH 08/12] linux-user: Add support for setting alsa timer enhanced read using ioctl, Aleksandar Markovic, 2020/01/15
- Re: [PATCH 08/12] linux-user: Add support for setting alsa timer enhanced read using ioctl, Aleksandar Markovic, 2020/01/16
- Re: [PATCH 08/12] linux-user: Add support for setting alsa timer enhanced read using ioctl, Arnd Bergmann, 2020/01/16
- Re: [PATCH 08/12] linux-user: Add support for setting alsa timer enhanced read using ioctl, Aleksandar Markovic, 2020/01/17