[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] hw/input: Do not enable CONFIG_PCKBD by default

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] hw/input: Do not enable CONFIG_PCKBD by default
Date: Wed, 15 Jan 2020 15:45:53 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2

On 1/15/20 12:46 PM, Laurent Vivier wrote:
Le 15/01/2020 à 12:37, Thomas Huth a écrit :
The i8042 device is part of the chipset of a machine, so it should
be selected by the machines or chipsets (e.g. SuperIO chipsets),
and not be enabled by default.

The sentence "The i8042 device is part of the chipset of a machine" sounds odd to me.

Maybe simply use "The i8042 PS/2 Controller should not be enabled by default. It has to be selected by machines or chipsets (e.g. SuperIO chipsets)."

Signed-off-by: Thomas Huth <address@hidden>
  hw/input/Kconfig | 1 -
  hw/isa/Kconfig   | 1 +
  2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/input/Kconfig b/hw/input/Kconfig
index 287f08887b..a2f25725be 100644
--- a/hw/input/Kconfig
+++ b/hw/input/Kconfig
@@ -7,7 +7,6 @@ config LM832X
config PCKBD
-    default y
      select PS2
      depends on ISA_BUS
diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
index 8a38813cc1..c7f07854f7 100644
--- a/hw/isa/Kconfig
+++ b/hw/isa/Kconfig
@@ -16,6 +16,7 @@ config I82378
  config ISA_SUPERIO
      select ISA_BUS
+    select PCKBD
config PC87312

It is also used by R4K but the Kconfig already includes it, so:

I believe R4K should 'select ISA_SUPERIO' but we don't have specs and this machine is deprecated, so I didn't bother improving it.

Reviewed-by: Laurent Vivier <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]